Bug 47528

Summary: new-run-webkit-tests: 'webkit-patch skipped-ports' introduced bad layering
Product: WebKit Reporter: Dirk Pranke <dpranke>
Component: Tools / TestsAssignee: Dirk Pranke <dpranke>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, eric, ojan, pnormand, tony
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: OS X 10.5   
Attachments:
Description Flags
Patch abarth: review+

Dirk Pranke
Reported 2010-10-11 18:12:29 PDT
bug 42832 / r66872 introduced some unfortunate layering/dependency violations, by making the Port classes depend on the test_expectations library. This should be cleaned up by adding a generic routine that depends on both modules.
Attachments
Patch (11.62 KB, patch)
2012-04-11 16:56 PDT, Dirk Pranke 		abarth: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Dirk Pranke
Comment 1 2012-04-11 16:56:04 PDT
Created attachment 136789 [details] Patch
Dirk Pranke
Comment 2 2012-04-11 17:13:52 PDT
Committed r113927: <http://trac.webkit.org/changeset/113927>
Note You need to log in before you can comment on or make changes to this bug.