Bug 46325

Summary: Rename FileWriterClient to AsyncFileWriterClient.
Product: WebKit Reporter: Eric U. <ericu>
Component: DOMAssignee: Eric U. <ericu>
Status: RESOLVED FIXED    
Severity: Enhancement CC: commit-queue, dumi, kinuko
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Bug Depends on:    
Bug Blocks: 44358    
Attachments:
Description Flags
Patch none

Eric U.
Reported 2010-09-22 17:50:14 PDT
As promised in https://bugs.webkit.org/show_bug.cgi?id=44361, I'll now rename FileWriterClient to AsyncFileWriterClient, which is more accurate, because it's the client of the AsyncFileWriter.
Attachments
Patch (22.69 KB, patch)
2010-09-22 20:33 PDT, Eric U. 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Eric U.
Comment 1 2010-09-22 20:33:49 PDT
Created attachment 68494 [details] Patch
Kinuko Yasuda
Comment 2 2010-09-22 20:52:11 PDT
Comment on attachment 68494 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=68494&action=review Thanks for changing this! Lgtm (except that the duplicated WebCore/fileapi/AsyncFileWriterClient.h) > WebCore/fileapi/AsyncFileWriterClient.h:1 > +/* Hmm I wonder how we got this duplicated file entry in this patch (we have correct version of WebCore/fileapi/AsyncFileWriterClient.h diff below...)
Eric U.
Comment 3 2010-09-23 08:41:33 PDT
(In reply to comment #2) > (From update of attachment 68494 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=68494&action=review > > Thanks for changing this! Lgtm (except that the duplicated WebCore/fileapi/AsyncFileWriterClient.h) > > > WebCore/fileapi/AsyncFileWriterClient.h:1 > > +/* > > Hmm I wonder how we got this duplicated file entry in this patch (we have correct version of WebCore/fileapi/AsyncFileWriterClient.h diff below...) Yeah, I'm not sure what's up with that. Perhaps that's how it shows an "svn mv" followed by editing? The patch came out of webkit-patch; I didn't create it manually. I can try svn-create-patch instead and see if it's any different when I get in to the office.
Eric U.
Comment 4 2010-09-23 10:33:09 PDT
(In reply to comment #3) > (In reply to comment #2) > > (From update of attachment 68494 [details] [details]) > > View in context: https://bugs.webkit.org/attachment.cgi?id=68494&action=review > > > > Thanks for changing this! Lgtm (except that the duplicated WebCore/fileapi/AsyncFileWriterClient.h) > > > > > WebCore/fileapi/AsyncFileWriterClient.h:1 > > > +/* > > > > Hmm I wonder how we got this duplicated file entry in this patch (we have correct version of WebCore/fileapi/AsyncFileWriterClient.h diff below...) > > Yeah, I'm not sure what's up with that. Perhaps that's how it shows an "svn mv" followed by editing? The patch came out of webkit-patch; I didn't create it manually. I can try svn-create-patch instead and see if it's any different when I get in to the office. I get the same patch from svn-create-patch; I think it's just trying to show a mv followed by an edit, so I'm guessing it's OK.
WebKit Commit Bot
Comment 5 2010-09-23 12:33:56 PDT
Comment on attachment 68494 [details] Patch Clearing flags on attachment: 68494 Committed r68180: <http://trac.webkit.org/changeset/68180>
WebKit Commit Bot
Comment 6 2010-09-23 12:34:01 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.