Bug 43115

Summary:

[Qt] QScriptValue should hhave API for accessing a private data.

Product:

WebKit

Reporter:

Jędrzej Nowacki <jedrzej.nowacki>

Component:

JavaScriptCore

Assignee:

Jędrzej Nowacki <jedrzej.nowacki>

Status:

RESOLVED WONTFIX

Severity:

Enhancement

CC:

cmarcelo, jedrzej.nowacki, kent.hansen

Priority:

Keywords:

Qt, QtTriaged

Version:

528+ (Nightly build)

Hardware:

All

OS:

All

Bug Depends on:

Bug Blocks:

31863

Attachments:

Description	Flags
Fix v1	ariya.hidayat: review-

Jędrzej Nowacki

Reported 2010-07-28 05:13:08 PDT

See http://doc.trolltech.com/4.6/qscriptvalue.html#data http://doc.trolltech.com/4.6/qscriptvalue.html#setData

Attachments
Fix v1 (6.32 KB, patch) 2010-07-28 05:16 PDT, Jędrzej Nowacki	ariya.hidayat: review-	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Jędrzej Nowacki

Comment 1 2010-07-28 05:16:15 PDT

Created attachment 62814 [details] Fix v1

Ariya Hidayat

Comment 2 2010-08-08 12:51:07 PDT

Comment on attachment 62814 [details] Fix v1 > + [Qt] QScriptValue should hhave API for accessing a private data. Typo at "hhave". > + QExplicitlySharedDataPointer<QScriptValuePrivate> m_objectData; Can't you use the new QSharedPointer instead? > +QScriptValuePrivate* QScriptValuePrivate::data() const > +{ > + if (m_objectData) > + return m_objectData.data(); > + return new QScriptValuePrivate(); > +} Is this asking for a leak? If there is a way to use QSharedPointer, we can even pass QSharedPointer back instead of raw pointer? r- for these minor issues. Otherwise LGTM.

Jędrzej Nowacki

Comment 3 2011-07-07 07:52:58 PDT

Porting QtScript API over JSC C API will not be continued.

Note You need to log in before you can comment on or make changes to this bug.