Bug 37426
| Summary: | new-run-webkit-tests should use the ServerProcess abstraction in chromium.py | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Dirk Pranke <dpranke> |
| Component: | Tools / Tests | Assignee: | Nobody <webkit-unassigned> |
| Status: | RESOLVED WONTFIX | ||
| Severity: | Normal | CC: | aroben, dpranke, tony |
| Priority: | P2 | ||
| Version: | 528+ (Nightly build) | ||
| Hardware: | PC | ||
| OS: | OS X 10.5 | ||
Dirk Pranke
The code to launch and read from test_shell in chromium.py predates the ServerProcess abstraction that WebKit Mac uses. It should be rewritten to use it to minimize code duplication.
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Dirk Pranke
Tony, I'm punting this over to you, because it becomes true when we remove the test_shell code and only use DRT.
Tony Chang
Ok, after we switch, I'll see about removing the test_shell related code.
Tony Chang
Hmm, as mentioned in bug 34826 comment 20, it is non-trivial to make use of ServerProcess on Windows python. I'm not sure if this is something we want to pursue.
Dirk Pranke
punting back to me ;)
Dirk Pranke
I don't think it should block bug 34984 and I plan to clear the blocking flag on Mon 4/11. If you disagree, now would be a good time to speak up :).
Dirk Pranke
clearing blocking flag.
Dirk Pranke
See bug 37426 for a way to make serverprocess work w/o blocking on win32.
Dirk Pranke
A more accurate description of this would probably be that we should just use the WebKitDriver implementation if we ever want to switch the Chromium DRT to webkit-style output.
Whether or not the WebKitDriver implementation works on windows is a separate issue that should probably be tracked under a separate bug.
I'm marking this as WONTFIX for now and clearing ownership; if anyone disagrees, feel free to reopen it.