Bug 284545
| Summary: | [scroll-animations] WPT test scroll-animations/scroll-timelines/scroll-animation-effect-phases.tentative.html has failures | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Antoine Quint <graouts> |
| Component: | Animations | Assignee: | Antoine Quint <graouts> |
| Status: | RESOLVED FIXED | ||
| Severity: | Normal | CC: | graouts, webkit-bug-importer |
| Priority: | P2 | Keywords: | InRadar |
| Version: | WebKit Nightly Build | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| See Also: | https://github.com/web-platform-tests/wpt/pull/50858 | ||
| Bug Depends on: | |||
| Bug Blocks: | 284541 | ||
Antoine Quint
The WPT test scroll-animations/scroll-timelines/scroll-animation-effect-phases.html has one failure:
FAIL Playback rate affects whether active phase boundary is inclusive. assert_not_equals: Animation effect is in active phase when current time is 100%. got disallowed value null
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Radar WebKit Bug Importer
<rdar://problem/141356963>
Antoine Quint
We fail the "Playback rate affects whether active phase boundary is inclusive" subtest in `scroll-animations/scroll-timelines/scroll-animation-effect-phases.tentative.html`. There are two issues here.
The first issue is a faulty assertion function where `assert_phase` does not deal with `currentTime = 100%` being in the "active" phase for animations associated with a progress-based timeline.
After fixing this we hit a debug ASSERT in WebKit though. Under `setBindingsTimeline()` at the very end of this test, when we change to the document timeline, we end up in a bad state where after calling `setCurrentTime()` the hold time is 0s but the start time is 100%. After that we set the hold time to the unresolved value since the start time is resolved. Then we're in a state where all the timing values are time-based except for the start time which remains progress-based.
The test attempts to resolve this by setting `animation.currentTime = 0` right after, but we hit the debug assertion before being able to set that value.
Antoine Quint
*** Bug 287793 has been marked as a duplicate of this bug. ***
Antoine Quint
Pull request: https://github.com/WebKit/WebKit/pull/41055
Antoine Quint
Submitted web-platform-tests pull request: https://github.com/web-platform-tests/wpt/pull/50858
EWS
Committed 290787@main (03eccf44ee0d): <https://commits.webkit.org/290787@main>
Reviewed commits have been landed. Closing PR #41055 and removing active labels.