Bug 278460
| Summary: | [GLib] Improve FPS counter | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Pawel Lampe <plampe> |
| Component: | WPE WebKit | Assignee: | Diego Pino <dpino> |
| Status: | RESOLVED FIXED | ||
| Severity: | Normal | CC: | bugs-noreply, dpino, webkit-bug-importer |
| Priority: | P2 | ||
| Version: | WebKit Nightly Build | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| Bug Depends on: | |||
| Bug Blocks: | 268972 | ||
Pawel Lampe
Currently - in skia builds - the FPS counter (that used to be shown when WEBKIT_SHOW_FPS=1) is not displayed
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Pawel Lampe
Pull request: https://github.com/WebKit/WebKit/pull/32580
Pawel Lampe
As drawing FPS counter interferes with the graphics pipeline it should be avoided - it would be ideal to log FPS instead.
EWS
Committed 294148@main (b7df35a60c2f): <https://commits.webkit.org/294148@main>
Reviewed commits have been landed. Closing PR #32580 and removing active labels.
Diego Pino
This changeset broke the build for WPE in ARM-32 bit architectures.
https://build.webkit.org/#/builders/860/builds/19500
The reason is the changeset made use of the data type `std::atomic<std::optional<double>>`. The size of an optional is the size of the data type it stores plus the size of bool, which in this case is 9-bytes. In 32-bit architectures, atomic data types larger than 8-bytes require linking with libatomic. There was a test in the CMake files to determining whether to link with libatomic or not, but this use case was not managed.
Diego Pino
Re-opening for pull request https://github.com/WebKit/WebKit/pull/44664
Diego Pino
Pull request: https://github.com/WebKit/WebKit/pull/44682
EWS
Committed 294245@main (20c693e72e84): <https://commits.webkit.org/294245@main>
Reviewed commits have been landed. Closing PR #44682 and removing active labels.