Bug 272142
| Summary: | Get Upstream Commit reference for people using a local source | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Karl Dubost <karlcow> |
| Component: | Tools / Tests | Assignee: | Karl Dubost <karlcow> |
| Status: | RESOLVED FIXED | ||
| Severity: | Normal | CC: | webkit-bug-importer |
| Priority: | P2 | Keywords: | InRadar |
| Version: | Other | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| Bug Depends on: | 248445 | ||
| Bug Blocks: | |||
Karl Dubost
Currently people using:
import-w3c-tests -t web-platform-tests/somewhere
will get after the import a message such as:
--------- Please include the following in your commit message: ---------
Upstream commit: https://github.com/web-platform-tests/wpt/commit/de2aecb1fca479ea8365dd795998e6ae1bcdd45f
------------------------------------------------------------------------
But people using a local source directory
import-w3c-tests web-platform-tests/somewhere -s ~/MyLocalWPTsrc/
will not get the message.
We can fix that.
commit message
https://searchfox.org/wubkat/rev/60ad4ce2c9dba49e168cb8048022d1e9baf67afc/Tools/Scripts/webkitpy/w3c/test_importer.py#653-656
self.upstream_revision initialization
https://searchfox.org/wubkat/rev/60ad4ce2c9dba49e168cb8048022d1e9baf67afc/Tools/Scripts/webkitpy/w3c/test_importer.py#206-211
It should be an easy fix.
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Radar WebKit Bug Importer
<rdar://problem/125894887>
Karl Dubost
Pull request: https://github.com/WebKit/WebKit/pull/29444
EWS
Committed 279698@main (83de710ceb2c): <https://commits.webkit.org/279698@main>
Reviewed commits have been landed. Closing PR #29444 and removing active labels.