Bug 245174
| Summary: | Align "UA" stylesheet for "hr" with HTML Spec | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Ahmad Saleem <ahmad.saleem792> |
| Component: | CSS | Assignee: | Nobody <webkit-unassigned> |
| Status: | RESOLVED DUPLICATE | ||
| Severity: | Normal | CC: | simon.fraser, webkit-bug-importer |
| Priority: | P2 | Keywords: | InRadar |
| Version: | Safari Technology Preview | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| See Also: | https://bugs.webkit.org/show_bug.cgi?id=245156 | ||
Ahmad Saleem
Originating from bug 245156
I tried to do all changes in one go and got quite a lot of failures and difficult to manage them, so I am going to separate them one by one and land them.
It would be easier to manage for me and this is about this one below:
2) hr element is missing "overflow: hidden".
https://html.spec.whatwg.org/#the-hr-element-2
In case, if I am not able to do it and had to close my PR, I will share details on genuine test failures or why this is no go at the moment for Webkit so someone else can take a look in future.
Thanks!
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Ahmad Saleem
Learning:
'hr' element change is troublesome because it leads to "render" layer being added and had to re baseline 200+ tests.
Although rebaselining is not the difficult part:
-> on 'win' bot, it leads to change in outline color being changed from 'blue' to 'black' and I don't know how to fix it.
-> on some WPT test cases in 'SELECTION', we start to fail them and they time out.
Although it leads to some passes as well.
___
PR to look into for future:
https://github.com/WebKit/WebKit/pull/4342
Radar WebKit Bug Importer
<rdar://problem/100218380>
Ahmad Saleem
*** This bug has been marked as a duplicate of bug 172801 ***