Bug 245174 - Align "UA" stylesheet for "hr" with HTML Spec
Summary: Align "UA" stylesheet for "hr" with HTML Spec
Status: RESOLVED DUPLICATE of bug 172801
Alias: None
Product: WebKit
Classification: Unclassified
Component: CSS (show other bugs)
Version: Safari Technology Preview
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2022-09-14 04:47 PDT by Ahmad Saleem
Modified: 2022-09-25 06:49 PDT (History)
2 users (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Ahmad Saleem 2022-09-14 04:47:40 PDT
Originating from bug 245156

I tried to do all changes in one go and got quite a lot of failures and difficult to manage them, so I am going to separate them one by one and land them.

It would be easier to manage for me and this is about this one below:

2) hr element is missing "overflow: hidden".

https://html.spec.whatwg.org/#the-hr-element-2

In case, if I am not able to do it and had to close my PR, I will share details on genuine test failures or why this is no go at the moment for Webkit so someone else can take a look in future.

Thanks!
Comment 1 Ahmad Saleem 2022-09-15 15:02:57 PDT
Learning:

'hr' element change is troublesome because it leads to "render" layer being added and had to re baseline 200+ tests.

Although rebaselining is not the difficult part:

-> on 'win' bot, it leads to change in outline color being changed from 'blue' to 'black' and I don't know how to fix it.
-> on some WPT test cases in 'SELECTION', we start to fail them and they time out.

Although it leads to some passes as well.

___

PR to look into for future:

https://github.com/WebKit/WebKit/pull/4342
Comment 2 Radar WebKit Bug Importer 2022-09-21 04:48:16 PDT
<rdar://problem/100218380>
Comment 3 Ahmad Saleem 2022-09-25 06:49:14 PDT

*** This bug has been marked as a duplicate of bug 172801 ***