Bug 239132
| Summary: | [GTK] Remove WebKitInstallMissingMediaPluginsPermissionRequest | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Michael Catanzaro <mcatanzaro> |
| Component: | WebKitGTK | Assignee: | Philippe Normand <philn> |
| Status: | RESOLVED FIXED | ||
| Severity: | Normal | CC: | bugs-noreply, mcatanzaro, philn, pnormand |
| Priority: | P2 | ||
| Version: | WebKit Nightly Build | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| See Also: |
https://bugs.webkit.org/show_bug.cgi?id=147822 https://bugs.webkit.org/show_bug.cgi?id=250376 |
||
| Bug Depends on: | |||
| Bug Blocks: | 210100 | ||
Michael Catanzaro
The WebKitInstallMissingMediaPluginsPermissionRequest API has been broken for six years, ever since we fixed bug #135972. Let's remove this from our GTK 4 API.
We might eventually create a new API to handle codec installation, see bug #147822, but I don't think it's terribly urgent or important. Normally you can either offer codecs and install them by default (e.g. Debian), or you can't offer them at all (e.g. Fedora). Having a codec installer that's either not needed or cannot work is not super useful either way.
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Michael Catanzaro
Note there are D-Bus permissions for this in XDGDBusProxy.cpp that should be removed.
Also we should deprecate the APIs in the old API version, as they haven't been deprecated yet.
Michael Catanzaro
Also should remove /webkit2/WebKitWebView/install-missing-plugins-permission-request and any failure expectations.
Philippe Normand
I agree, I'll prepare a patch for this.
Philippe Normand
Pull request: https://github.com/WebKit/WebKit/pull/8232
EWS
Committed 258653@main (209971efaec5): <https://commits.webkit.org/258653@main>
Reviewed commits have been landed. Closing PR #8232 and removing active labels.