Bug 236487

Summary: WebGL context should use discrete gpu if the context is created when the window is on external monitor, ANGLE Metal backend
Product: WebKit Reporter: Kimmo Kinnunen <kkinnunen>
Component: WebGLAssignee: Kimmo Kinnunen <kkinnunen>
Status: RESOLVED FIXED    
Severity: Normal CC: cdumez, changseok, dino, esprehn+autocc, ews-watchlist, geofflang, gman, gyuyoung.kim, jonahr, kbr, kkinnunen, kondapallykalyan, kpiddington, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: Other   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=237597
Bug Depends on: 237313, 237522    
Bug Blocks: 223434    
Attachments:
Description Flags
WIP for monday
none
Patch
none
Patch for landing none

Kimmo Kinnunen
Reported 2022-02-10 23:30:39 PST
WebGL context should use discrete gpu if the context is created when the window is on external monitor
Attachments
WIP for monday (28.99 KB, patch)
2022-03-04 06:34 PST, Kimmo Kinnunen 		no flags
DetailsFormatted DiffDiff
Patch (26.42 KB, patch)
2022-03-08 05:22 PST, Kimmo Kinnunen 		no flags
DetailsFormatted DiffDiff
Patch for landing (27.64 KB, patch)
2022-03-09 01:19 PST, Kimmo Kinnunen 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2022-02-17 23:31:17 PST
<rdar://problem/89131272>
Kimmo Kinnunen
Comment 2 2022-03-04 06:34:16 PST
Created attachment 453837 [details] WIP for monday
Kimmo Kinnunen
Comment 3 2022-03-08 05:22:47 PST
Created attachment 454109 [details] Patch
Kenneth Russell
Comment 4 2022-03-08 13:16:20 PST
Adding Kyle and ANGLE folks as FYI.
Kenneth Russell
Comment 5 2022-03-08 13:21:10 PST
Comment on attachment 454109 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=454109&action=review Looks great. A couple of small comments, but r+. > Source/WebCore/platform/graphics/cocoa/GraphicsContextGLCocoa.mm:161 > + // is anyway already powered on. Perhaps mention here that this code relies on the assumption that EGL_ANGLE_platform_angle_device_id uses the IOKit registry ID of the GPU on Mac platforms? > Source/WebCore/platform/graphics/cocoa/GraphicsContextGLCocoa.mm:163 > + displayAttributes.append(EGL_PLATFORM_ANGLE_DEVICE_ID_HIGH_ANGLE); Would you like to at least ASSERT the availability of the EGL_ANGLE_platform_angle_device_id EGL client extension somewhere?
Kimmo Kinnunen
Comment 6 2022-03-09 01:19:39 PST
Created attachment 454207 [details] Patch for landing
EWS
Comment 7 2022-03-14 05:46:47 PDT
Committed r291224 (248379@main): <https://commits.webkit.org/248379@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 454207 [details].
Note You need to log in before you can comment on or make changes to this bug.