Bug 237522 - ANGLE display cache does not work with explicit device ids
Summary: ANGLE display cache does not work with explicit device ids
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebGL (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Kimmo Kinnunen
URL:
Keywords: InRadar
Depends on:
Blocks: 236487
  Show dependency tree / graph
 
Reported: 2022-03-07 04:17 PST by Kimmo Kinnunen
Modified: 2022-03-09 06:35 PST (History)
10 users (show)

See Also:

Attachments
Patch (5.19 KB, patch)
2022-03-07 04:30 PST, Kimmo Kinnunen 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Kimmo Kinnunen 2022-03-07 04:17:51 PST 
ANGLE display cache does not work with explicit device ids
Comment 1 Kimmo Kinnunen 2022-03-07 04:30:55 PST 
Created attachment 453964 [details]
Patch
Comment 2 EWS Watchlist 2022-03-07 04:32:37 PST 
Note that there are important steps to take when updating ANGLE. See https://trac.webkit.org/wiki/UpdatingANGLE
Comment 3 Kenneth Russell 2022-03-07 12:53:02 PST 
Comment on attachment 453964 [details]
Patch

Looks good to me. r+

The win EWS bot failure is unrelated flakiness.

Please upstream this as soon as possible to avoid duplicate work and reduce the chance of conflicts being introduced. Thanks.
Comment 4 Kimmo Kinnunen 2022-03-07 23:37:41 PST 
Comment on attachment 453964 [details]
Patch

thanks!
Comment 5 EWS 2022-03-08 05:43:21 PST 
Committed r290987 (248165@main): <https://commits.webkit.org/248165@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 453964 [details].
Comment 6 Radar WebKit Bug Importer 2022-03-08 05:44:16 PST 
<rdar://problem/89963372>