Bug 204267

Summary: REGRESSION (r252497): Multiple mediacapturefromelement tests are crashing on mac debug
Product: WebKit Reporter: Aakash Jain <aakash_jain>
Component: WebKit Misc.Assignee: Chris Dumez <cdumez>
Status: RESOLVED FIXED    
Severity: Normal CC: aakash_jain, achristensen, ap, cdumez, commit-queue, dbates, eric.carlson, esprehn+autocc, ews-watchlist, ggaren, glenn, hta, jbedard, jer.noble, kangil.han, philipj, rniwa, sergio, tommyw, tsavell, webkit-bot-watchers-bugzilla, webkit-bug-importer, youennf
Priority: P2 Keywords: InRadar
Version: Other   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 204232    
Attachments:
Description Flags
Patch
none
Patch
none
Patch none

Aakash Jain
Reported 2019-11-15 17:40:30 PST
Multiple mediacapturefromelement tests are crashing on mac debug (mojave, high-sierra, Catalina), e.g.: fast/mediacapturefromelement/CanvasCaptureMediaStream-2d-events.html fast/mediacapturefromelement/CanvasCaptureMediaStream-clone-track.html fast/mediacapturefromelement/CanvasCaptureMediaStream-creation.html Build: https://build.webkit.org/results/Apple%20Mojave%20Debug%20WK1%20(Tests)/r252500%20(6925)/results.html Flakiness dashboard: https://results.webkit.org/?suite=layout-tests&suite=layout-tests&suite=layout-tests&test=fast%2Fmediacapturefromelement%2FCanvasCaptureMediaStream-clone-track.html&test=fast%2Fmediacapturefromelement%2FCanvasCaptureMediaStream-creation.html&test=http%2Fwpt%2Fmediarecorder%2FMediaRecorder-AV-audio-video-dataavailable.html Seems to be regression between r252500 and r252497. Probably https://trac.webkit.org/changeset/252500/webkit
Attachments
Patch (2.07 KB, patch)
2019-11-15 19:15 PST, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Patch (2.08 KB, patch)
2019-11-15 19:17 PST, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Patch (4.61 KB, patch)
2019-11-18 08:47 PST, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Alexey Proskuryakov
Comment 1 2019-11-15 19:00:56 PST
Thread 0 Crashed:: Dispatch queue: com.apple.main-thread 0 com.apple.JavaScriptCore 0x000000010bca5db0 WTFCrash + 16 (Assertions.cpp:305) 1 com.apple.WebCore 0x000000011bb76b3b WTFCrashWithInfo(int, char const*, char const*, int) + 27 2 com.apple.WebCore 0x000000011de910f8 WebCore::ActiveDOMObject::assertSuspendIfNeededWasCalled() const + 104 (ActiveDOMObject.cpp:102) 3 com.apple.WebCore 0x000000011e0db9b4 WebCore::ScriptExecutionContext::checkConsistency() const + 820 4 com.apple.WebCore 0x000000011e0dc9e0 WebCore::ScriptExecutionContext::canSuspendActiveDOMObjectsForDocumentSuspension(WTF::Vector<WebCore::ActiveDOMObject*, 0ul, WTF::CrashOnOverflow, 16ul>*) + 32 (ScriptExecutionContext.cpp:227) 5 com.apple.WebCore 0x000000011e2cc050 WebCore::canCacheFrame(WebCore::Frame&, WebCore::DiagnosticLoggingClient&, unsigned int) + 3504 (BackForwardCache.cpp:165)
Radar WebKit Bug Importer
Comment 2 2019-11-15 19:02:04 PST
<rdar://problem/57248130>
Chris Dumez
Comment 3 2019-11-15 19:09:01 PST
Looks like somebody forgot to call SuspendIfNeeded() for an ActiveDOMObject.
Chris Dumez
Comment 4 2019-11-15 19:10:07 PST
(In reply to Aakash Jain from comment #0) > Multiple mediacapturefromelement tests are crashing on mac debug (mojave, > high-sierra, Catalina), e.g.: > > fast/mediacapturefromelement/CanvasCaptureMediaStream-2d-events.html > fast/mediacapturefromelement/CanvasCaptureMediaStream-clone-track.html > fast/mediacapturefromelement/CanvasCaptureMediaStream-creation.html > > > Build: > https://build.webkit.org/results/Apple%20Mojave%20Debug%20WK1%20(Tests)/ > r252500%20(6925)/results.html > > Flakiness dashboard: > https://results.webkit.org/?suite=layout-tests&suite=layout- > tests&suite=layout- > tests&test=fast%2Fmediacapturefromelement%2FCanvasCaptureMediaStream-clone- > track.html&test=fast%2Fmediacapturefromelement%2FCanvasCaptureMediaStream- > creation.html&test=http%2Fwpt%2Fmediarecorder%2FMediaRecorder-AV-audio-video- > dataavailable.html > > > Seems to be regression between r252500 and r252497. Probably > https://trac.webkit.org/changeset/252500/webkit It cannot be https://trac.webkit.org/changeset/252500/webkit
Alexey Proskuryakov
Comment 5 2019-11-15 19:11:06 PST
Actually, this is almost certainly r252497. Which was itself a fix for assertion failures.
Chris Dumez
Comment 6 2019-11-15 19:12:03 PST
(In reply to Alexey Proskuryakov from comment #5) > Actually, this is almost certainly r252497. Which was itself a fix for > assertion failures. Looking now.
Chris Dumez
Comment 7 2019-11-15 19:15:13 PST
Created attachment 383680 [details] Patch
Chris Dumez
Comment 8 2019-11-15 19:17:44 PST
Created attachment 383681 [details] Patch
WebKit Commit Bot
Comment 9 2019-11-15 21:45:20 PST
Comment on attachment 383681 [details] Patch Clearing flags on attachment: 383681 Committed r252524: <https://trac.webkit.org/changeset/252524>
WebKit Commit Bot
Comment 10 2019-11-15 21:45:21 PST
All reviewed patches have been landed. Closing bug.
Truitt Savell
Comment 11 2019-11-18 08:34:01 PST
It looks like fast/mediacapturefromelement/CanvasCaptureMediaStream-creation.html and fast/mediacapturefromelement/CanvasCaptureMediaStream-clone-track.html are still crashing
Chris Dumez
Comment 12 2019-11-18 08:34:34 PST
(In reply to Truitt Savell from comment #11) > It looks like > fast/mediacapturefromelement/CanvasCaptureMediaStream-creation.html > and fast/mediacapturefromelement/CanvasCaptureMediaStream-clone-track.html > are still crashing Odd, will look now although it would help to get a link.
Chris Dumez
Comment 14 2019-11-18 08:37:24 PST
(In reply to Chris Dumez from comment #12) > (In reply to Truitt Savell from comment #11) > > It looks like > > fast/mediacapturefromelement/CanvasCaptureMediaStream-creation.html > > and fast/mediacapturefromelement/CanvasCaptureMediaStream-clone-track.html > > are still crashing > > Odd, will look now although it would help to get a link. I can reproduce the crash for fast/mediacapturefromelement/CanvasCaptureMediaStream-creation.html and will get a fix shortly.
Chris Dumez
Comment 15 2019-11-18 08:45:13 PST
Reopening for follow-up fix.
Chris Dumez
Comment 16 2019-11-18 08:47:30 PST
Created attachment 383751 [details] Patch
WebKit Commit Bot
Comment 17 2019-11-18 09:34:41 PST
Comment on attachment 383751 [details] Patch Clearing flags on attachment: 383751 Committed r252545: <https://trac.webkit.org/changeset/252545>
WebKit Commit Bot
Comment 18 2019-11-18 09:34:43 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.