Bug 178050

Summary: Use one virtual allocation for all gigacages and their runways
Product: WebKit Reporter: Filip Pizlo <fpizlo>
Component: bmallocAssignee: Filip Pizlo <fpizlo>
Status: RESOLVED DUPLICATE    
Severity: Normal CC: buildbot, commit-queue, ggaren, saam, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: All   
OS: All   
Bug Depends on: 178182    
Bug Blocks: 174917    
Attachments:
Description Flags
wip
none
the patch
none
the patch
none
the patch
none
the patch
saam: review+
patch for landing none

Filip Pizlo
Reported 2017-10-07 09:51:32 PDT
Patch forthcoming.
Attachments
wip (16.36 KB, patch)
2017-10-07 14:00 PDT, Filip Pizlo 		no flags
DetailsFormatted DiffDiff
the patch (16.57 KB, patch)
2017-10-07 17:52 PDT, Filip Pizlo 		no flags
DetailsFormatted DiffDiff
the patch (16.40 KB, patch)
2017-10-07 19:01 PDT, Filip Pizlo 		no flags
DetailsFormatted DiffDiff
the patch (16.19 KB, patch)
2017-10-07 20:33 PDT, Filip Pizlo 		no flags
DetailsFormatted DiffDiff
the patch (16.22 KB, patch)
2017-10-07 20:34 PDT, Filip Pizlo 		saam: review+
DetailsFormatted DiffDiff
patch for landing (16.87 KB, patch)
2017-10-09 20:43 PDT, Filip Pizlo 		no flags
DetailsFormatted DiffDiff
Show Obsolete (5) View All Add attachment proposed patch, testcase, etc.
Filip Pizlo
Comment 1 2017-10-07 14:00:08 PDT
Created attachment 323101 [details] wip
Filip Pizlo
Comment 2 2017-10-07 17:52:04 PDT
Created attachment 323109 [details] the patch
Filip Pizlo
Comment 3 2017-10-07 19:01:37 PDT
Created attachment 323114 [details] the patch
Filip Pizlo
Comment 4 2017-10-07 20:33:31 PDT
Created attachment 323118 [details] the patch
Filip Pizlo
Comment 5 2017-10-07 20:34:47 PDT
Created attachment 323119 [details] the patch
Build Bot
Comment 6 2017-10-08 01:14:35 PDT
Attachment 323119 [details] did not pass style-queue: ERROR: Source/bmalloc/bmalloc/CryptoRandom.cpp:26: Found header this file implements before WebCore config.h. Should be: config.h, primary header, blank line, and then alphabetically sorted. [build/include_order] [4] Total errors found: 1 in 7 files If any of these errors are false positives, please file a bug against check-webkit-style.
Filip Pizlo
Comment 7 2017-10-09 20:43:12 PDT
Created attachment 323280 [details] patch for landing
Build Bot
Comment 8 2017-10-09 20:44:50 PDT
Attachment 323280 [details] did not pass style-queue: ERROR: Source/bmalloc/bmalloc/CryptoRandom.cpp:26: Found header this file implements before WebCore config.h. Should be: config.h, primary header, blank line, and then alphabetically sorted. [build/include_order] [4] Total errors found: 1 in 8 files If any of these errors are false positives, please file a bug against check-webkit-style.
Filip Pizlo
Comment 9 2017-10-09 21:28:36 PDT
Landed in https://trac.webkit.org/changeset/223121/webkit
Radar WebKit Bug Importer
Comment 10 2017-10-09 21:29:39 PDT
<rdar://problem/34902910>
WebKit Commit Bot
Comment 11 2017-10-11 12:31:22 PDT
Re-opened since this is blocked by bug 178182
Filip Pizlo
Comment 12 2017-10-12 09:02:38 PDT
*** This bug has been marked as a duplicate of bug 177586 ***
Note You need to log in before you can comment on or make changes to this bug.