Bug 153546

Summary: Air::TmpWidth uses a stale pointer into its HashMap after it calls add()
Product: WebKit Reporter: Filip Pizlo <fpizlo>
Component: JavaScriptCoreAssignee: Filip Pizlo <fpizlo>
Status: RESOLVED FIXED    
Severity: Normal CC: barraclough, benjamin, ggaren, keith_miller, mark.lam, mhahnenb, msaboff, oliver, saam, sam
Priority: P2    
Version: WebKit Nightly Build   
Hardware: All   
OS: All   
Bug Depends on:    
Bug Blocks: 150279    
Attachments:
Description Flags
the patch saam: review+

Filip Pizlo
Reported 2016-01-27 09:07:30 PST
Patch forthcoming.
Attachments
the patch (2.46 KB, patch)
2016-01-27 09:10 PST, Filip Pizlo 		saam: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Filip Pizlo
Comment 1 2016-01-27 09:10:39 PST
Created attachment 270001 [details] the patch
Saam Barati
Comment 2 2016-01-27 11:01:13 PST
Comment on attachment 270001 [details] the patch View in context: https://bugs.webkit.org/attachment.cgi?id=270001&action=review r=me > Source/JavaScriptCore/b3/air/AirTmpWidth.cpp:142 > + // We already ensures that both tmps are added to the width map. That's important I don't think this comment is needed given the above. If you think we need is, "ensures" => "ensure"
Filip Pizlo
Comment 3 2016-01-27 12:11:21 PST
Landed in http://trac.webkit.org/changeset/195683
Note You need to log in before you can comment on or make changes to this bug.