Bug 152968

Summary: Turn Check(true) into Patchpoint() followed by Oops
Product: WebKit Reporter: Filip Pizlo <fpizlo>
Component: JavaScriptCoreAssignee: Filip Pizlo <fpizlo>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, keith_miller, mark.lam, msaboff, saam
Priority: P2    
Version: WebKit Nightly Build   
Hardware: All   
OS: All   
Bug Depends on:    
Bug Blocks: 152162, 150507    
Attachments:
Description Flags
the patch benjamin: review+

Filip Pizlo
Reported 2016-01-10 20:11:59 PST
Patch forthcoming.
Attachments
the patch (8.00 KB, patch)
2016-01-10 20:16 PST, Filip Pizlo 		benjamin: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Filip Pizlo
Comment 1 2016-01-10 20:16:24 PST
Created attachment 268669 [details] the patch
WebKit Commit Bot
Comment 2 2016-01-10 20:18:07 PST
Attachment 268669 [details] did not pass style-queue: ERROR: Source/JavaScriptCore/b3/B3InsertionSet.h:65: The parameter name "arguments" adds no information, so it should be removed. [readability/parameter_name] [5] Total errors found: 1 in 9 files If any of these errors are false positives, please file a bug against check-webkit-style.
Benjamin Poulain
Comment 3 2016-01-11 04:54:57 PST
Comment on attachment 268669 [details] the patch IMHO, it would be valuable to have 2 new tests in testbed for the new strength reduction.
Filip Pizlo
Comment 4 2016-01-11 09:15:26 PST
(In reply to comment #3) > Comment on attachment 268669 [details] > the patch > > IMHO, it would be valuable to have 2 new tests in testbed for the new > strength reduction. I added such tests.
Filip Pizlo
Comment 5 2016-01-11 09:18:54 PST
Landed in http://trac.webkit.org/changeset/194855
Note You need to log in before you can comment on or make changes to this bug.