Bug 147447

Summary:

jsc-tailcall: Don't waste stack space when arity fixup was performed

Product:

WebKit

Reporter:

Basile Clement <basile_clement>

Component:

JavaScriptCore

Assignee:

Basile Clement <basile_clement>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

fpizlo, ggaren, mark.lam, mmirman, msaboff, saam

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Bug Depends on:

Bug Blocks:

146477

Attachments:

Description	Flags
Patch	none
Patch	none
Patch	msaboff: review+

Basile Clement

Reported 2015-07-30 10:53:39 PDT

Currently when doing a tail call we overwrite only the number of arguments present in the call frame. However, we could have performed an arity fixup and must use the CodeBlock's number of parameters instead if it is higher.

Attachments
Patch (12.17 KB, patch) 2015-07-30 10:56 PDT, Basile Clement	no flags	Details Formatted Diff Diff
Patch (12.45 KB, patch) 2015-07-31 13:13 PDT, Basile Clement	no flags	Details Formatted Diff Diff
Patch (8.72 KB, patch) 2015-07-31 13:21 PDT, Basile Clement	msaboff: review+	Details Formatted Diff Diff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.