Bug 143732

Summary: Correct layering violation in DumpRenderTree Build
Product: WebKit Reporter: Brent Fulgham <bfulgham>
Component: Tools / TestsAssignee: Brent Fulgham <bfulgham>
Status: RESOLVED FIXED    
Severity: Normal CC: bfulgham, simon.fraser
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Bug Depends on:    
Bug Blocks: 143684    
Attachments:
Description Flags
Patch simon.fraser: review+

Brent Fulgham
Reported 2015-04-14 15:19:40 PDT
In Bug 143286, I introduced a layering violation between DumpRenderTree and WebCore. Instead of accessing WebCore types directly, DRT needs to pass through the WebCoreTestSupport library to manipulate WebCore state.
Attachments
Patch (5.73 KB, patch)
2015-04-14 16:02 PDT, Brent Fulgham 		simon.fraser: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Brent Fulgham
Comment 1 2015-04-14 16:02:24 PDT
Created attachment 250750 [details] Patch
Brent Fulgham
Comment 2 2015-04-14 16:48:58 PDT
Committed r182821: <http://trac.webkit.org/changeset/182821>
Note You need to log in before you can comment on or make changes to this bug.