Bug 135225

Summary:

Web Inspector: add eject current recording button to the replay dashboard

Product:

WebKit

Reporter:

Brian Burg <burg>

Component:

Web Inspector

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED LATER

Severity:

Normal

CC:

graouts, inspector-bugzilla-changes, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

528+ (Nightly build)

Hardware:

All

OS:

All

Bug Depends on:

135170, 135212

Bug Blocks:

136292

Attachments:

Description	Flags
Patch	none
Patch	none

Brian Burg

Reported 2014-07-23 18:24:43 PDT

Requires some plumbing!

Attachments
Patch (16.64 KB, patch) 2014-07-23 18:50 PDT, Brian Burg	no flags	Details Formatted Diff Diff
Patch (14.89 KB, patch) 2014-08-11 17:37 PDT, Brian Burg	no flags	Details Formatted Diff Diff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.

Radar WebKit Bug Importer

Comment 1 2014-07-23 18:24:52 PDT

<rdar://problem/17789274>

Brian Burg

Comment 2 2014-07-23 18:50:16 PDT

Created attachment 235401 [details] Patch

Timothy Hatcher

Comment 3 2014-08-05 11:38:21 PDT

I am not sure the dashboard is the right place for this. I would expect to see if in the control navigation bar in the Timeline sidebar.

Timothy Hatcher

Comment 4 2014-08-05 11:39:14 PDT

Though I suppose it can be in both places, like the Debugger dashboard has resume. Is eject a common enough action to put into the dashboard that you need to do it while looking at other views/sidebars?

Brian Burg

Comment 5 2014-08-11 17:37:07 PDT

Created attachment 236417 [details] Patch

Brian Burg

Comment 6 2014-08-11 17:42:27 PDT

(In reply to comment #4) > Though I suppose it can be in both places, like the Debugger dashboard has resume. Is eject a common enough action to put into the dashboard that you need to do it while looking at other views/sidebars? Eject is a common action, because it unlocks user input and other controls on determinism. So if you had been interacting with a captured execution, ejecting the current session will allow new user inputs, navigations, timers, etc to be processed. I do think that it also belongs in the timelines sidebar panel navigation bar. Those buttons need to be updated: currently they do not listen for replay events (paused, ejected, etc) so they don't always match the dashboard buttons. The important parts of this patch are the additions to the protocol and manager that implement an "eject" operation. The buttons are a way to test this until replay recordings and timeline recordings are better integrated in the UI.

Brian Burg

Comment 7 2014-08-11 17:44:51 PDT

Comment on attachment 236417 [details] Patch This is rebaselined and follows new conventions for promise-based APIs.

Timothy Hatcher

Comment 8 2014-08-11 19:41:54 PDT

Maybe eject and the icon are not the best terms. Maybe a mouse icon or something like that would be better? Maybe it could be crossed out or locked when replaying. As a user I wouldn't think eject meant I could interact with the page again. I would almost think unload the page and go to about:blank.

Blaze Burg

Comment 9 2017-07-10 14:01:29 PDT

Closing web replay-related bugs until we resume working on the feature again.

Note You need to log in before you can comment on or make changes to this bug.