Bug 127257

<rdar://problem/15855212>

Created attachment 221596 [details] Patch

Upload a patch to test build.

The patch isn't quite ready. It's mostly about understanding what other ports will do when they see the new gl functions. I expect they'll fail to compile.

Attachment 221596 [details] did not pass style-queue: ERROR: Source/WebCore/platform/graphics/opengl/GraphicsContext3DOpenGLCommon.cpp:1633: Wrong number of spaces before statement. (expected: 8) [whitespace/indent] [4] ERROR: Source/WebCore/platform/graphics/opengl/GraphicsContext3DOpenGLCommon.cpp:1636: Wrong number of spaces before statement. (expected: 8) [whitespace/indent] [4] ERROR: Source/WebCore/platform/graphics/opengl/GraphicsContext3DOpenGLCommon.cpp:1639: Wrong number of spaces before statement. (expected: 8) [whitespace/indent] [4] ERROR: Source/WebCore/platform/graphics/opengl/GraphicsContext3DOpenGLCommon.cpp:1642: Wrong number of spaces before statement. (expected: 8) [whitespace/indent] [4] ERROR: Source/WebCore/platform/graphics/opengl/GraphicsContext3DOpenGLCommon.cpp:1646: Wrong number of spaces before statement. (expected: 8) [whitespace/indent] [4] ERROR: Source/WebCore/platform/graphics/opengl/GraphicsContext3DOpenGLCommon.cpp:1649: Wrong number of spaces before statement. (expected: 8) [whitespace/indent] [4] ERROR: Source/WebCore/platform/graphics/GraphicsContext3D.h:428: enum members should use InterCaps with an initial capital letter. [readability/enum_casing] [4] ERROR: Source/WebCore/platform/graphics/GraphicsContext3D.h:429: enum members should use InterCaps with an initial capital letter. [readability/enum_casing] [4] ERROR: Source/WebCore/html/canvas/WebGLRenderingContext.cpp:2029: A case label should not be indented, but line up with its switch statement. [whitespace/indent] [4] ERROR: Source/WebCore/ChangeLog:8: You should remove the 'No new tests' and either add and list tests, or explain why no new tests were possible. [changelog/nonewtests] [5] ERROR: Source/WebCore/CMakeLists.txt:2668: Alphabetical sorting problem. "platform/text/TextCodecICU.cpp" should be before "platform/text/icu/UTextProviderUTF16.cpp". [list/order] [5] Total errors found: 11 in 20 files If any of these errors are false positives, please file a bug against check-webkit-style.

Comment on attachment 221596 [details] Patch Attachment 221596 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.appspot.com/results/5723923182256128 New failing tests: fast/canvas/webgl/oes-texture-half-float.html

Created attachment 221599 [details] Archive of layout-test-results from webkit-ews-15 for mac-mountainlion-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: webkit-ews-15 Port: mac-mountainlion-wk2 Platform: Mac OS X 10.8.5

Comment on attachment 221596 [details] Patch Attachment 221596 [details] did not pass mac-ews (mac): Output: http://webkit-queues.appspot.com/results/5213381493522432 New failing tests: fast/canvas/webgl/oes-texture-half-float.html

Created attachment 221601 [details] Archive of layout-test-results from webkit-ews-03 for mac-mountainlion The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: webkit-ews-03 Port: mac-mountainlion Platform: Mac OS X 10.8.5

Comment on attachment 221596 [details] Patch Attachment 221596 [details] did not pass mac-ews (mac): Output: http://webkit-queues.appspot.com/results/5117696265945088 New failing tests: fast/canvas/webgl/oes-texture-half-float.html

Created attachment 221603 [details] Archive of layout-test-results from webkit-ews-01 for mac-mountainlion The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: webkit-ews-01 Port: mac-mountainlion Platform: Mac OS X 10.8.5

Created attachment 221677 [details] Patch

Attachment 221677 [details] did not pass style-queue: ERROR: Source/WebCore/platform/graphics/GraphicsContext3D.h:428: enum members should use InterCaps with an initial capital letter. [readability/enum_casing] [4] ERROR: Source/WebCore/platform/graphics/GraphicsContext3D.h:429: enum members should use InterCaps with an initial capital letter. [readability/enum_casing] [4] ERROR: Source/WebCore/ChangeLog:8: You should remove the 'No new tests' and either add and list tests, or explain why no new tests were possible. [changelog/nonewtests] [5] ERROR: Source/WebCore/CMakeLists.txt:2668: Alphabetical sorting problem. "platform/text/TextCodecICU.cpp" should be before "platform/text/icu/UTextProviderUTF16.cpp". [list/order] [5] Total errors found: 4 in 20 files If any of these errors are false positives, please file a bug against check-webkit-style.

Comment on attachment 221677 [details] Patch Attachment 221677 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.appspot.com/results/5956872209170432 New failing tests: fast/canvas/webgl/oes-texture-half-float.html

Created attachment 221681 [details] Archive of layout-test-results from webkit-ews-14 for mac-mountainlion-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: webkit-ews-14 Port: mac-mountainlion-wk2 Platform: Mac OS X 10.8.5

Comment on attachment 221677 [details] Patch Attachment 221677 [details] did not pass mac-ews (mac): Output: http://webkit-queues.appspot.com/results/5771939842883584 New failing tests: fast/canvas/webgl/oes-texture-half-float.html

Created attachment 221683 [details] Archive of layout-test-results from webkit-ews-01 for mac-mountainlion The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: webkit-ews-01 Port: mac-mountainlion Platform: Mac OS X 10.8.5

Comment on attachment 221677 [details] Patch Attachment 221677 [details] did not pass mac-ews (mac): Output: http://webkit-queues.appspot.com/results/6286037227667456 New failing tests: fast/canvas/webgl/oes-texture-half-float.html

Created attachment 221689 [details] Archive of layout-test-results from webkit-ews-06 for mac-mountainlion The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: webkit-ews-06 Port: mac-mountainlion Platform: Mac OS X 10.8.5

Created attachment 221691 [details] Patch

Attachment 221691 [details] did not pass style-queue: ERROR: Source/WebCore/CMakeLists.txt:2669: Alphabetical sorting problem. "platform/text/TextCodecICU.cpp" should be before "platform/text/icu/UTextProviderUTF16.cpp". [list/order] [5] ERROR: Source/WebCore/platform/graphics/GraphicsContext3D.h:428: enum members should use InterCaps with an initial capital letter. [readability/enum_casing] [4] ERROR: Source/WebCore/platform/graphics/GraphicsContext3D.h:429: enum members should use InterCaps with an initial capital letter. [readability/enum_casing] [4] Total errors found: 3 in 25 files If any of these errors are false positives, please file a bug against check-webkit-style.

Comment on attachment 221691 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=221691&action=review Looks good to me, modulo the efl build error. r=me > Source/WebCore/DerivedSources.cpp:30 > +#include "JSANGLEInstancedArrays.cpp" Should this be protected by #if ENABLE(WEBGL)?

Comment on attachment 221691 [details] Patch Attachment 221691 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.appspot.com/results/4620986318061568 New failing tests: fast/canvas/webgl/angle-instanced-arrays.html

Created attachment 221694 [details] Archive of layout-test-results from webkit-ews-16 for mac-mountainlion-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: webkit-ews-16 Port: mac-mountainlion-wk2 Platform: Mac OS X 10.8.5

Comment on attachment 221691 [details] Patch Attachment 221691 [details] did not pass mac-ews (mac): Output: http://webkit-queues.appspot.com/results/6439109862096896 New failing tests: fast/canvas/webgl/angle-instanced-arrays.html

Created attachment 221698 [details] Archive of layout-test-results from webkit-ews-03 for mac-mountainlion The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: webkit-ews-03 Port: mac-mountainlion Platform: Mac OS X 10.8.5

Comment on attachment 221691 [details] Patch Attachment 221691 [details] did not pass mac-ews (mac): Output: http://webkit-queues.appspot.com/results/6146376366817280 New failing tests: fast/canvas/webgl/angle-instanced-arrays.html

Created attachment 221703 [details] Archive of layout-test-results from webkit-ews-07 for mac-mountainlion The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: webkit-ews-07 Port: mac-mountainlion Platform: Mac OS X 10.8.5

Created attachment 221899 [details] Patch

Incorporated Brent's review comment. Trying to see if I can get it to compile before landing. Not sure why the new test failed on mac :(

Attachment 221899 [details] did not pass style-queue: ERROR: Source/WebCore/CMakeLists.txt:2669: Alphabetical sorting problem. "platform/text/TextCodecICU.cpp" should be before "platform/text/icu/UTextProviderUTF16.cpp". [list/order] [5] ERROR: Source/WebCore/platform/graphics/opengl/GraphicsContext3DOpenGL.cpp:355: Wrong number of spaces before statement. (expected: 12) [whitespace/indent] [4] ERROR: Source/WebCore/platform/graphics/opengl/GraphicsContext3DOpenGL.cpp:355: Wrong number of spaces before statement. (expected: 12) [whitespace/indent] [4] ERROR: Source/WebCore/platform/graphics/opengl/GraphicsContext3DOpenGL.cpp:355: Wrong number of spaces before statement. (expected: 8) [whitespace/indent] [4] ERROR: Source/WebCore/platform/graphics/opengl/GraphicsContext3DOpenGL.cpp:355: Wrong number of spaces before statement. (expected: 8) [whitespace/indent] [4] ERROR: Source/WebCore/platform/graphics/GraphicsContext3D.h:428: enum members should use InterCaps with an initial capital letter. [readability/enum_casing] [4] ERROR: Source/WebCore/platform/graphics/GraphicsContext3D.h:429: enum members should use InterCaps with an initial capital letter. [readability/enum_casing] [4] Total errors found: 7 in 26 files If any of these errors are false positives, please file a bug against check-webkit-style.

Comment on attachment 221899 [details] Patch Attachment 221899 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.appspot.com/results/5804113644224512 New failing tests: fast/canvas/webgl/angle-instanced-arrays.html

Created attachment 221904 [details] Archive of layout-test-results from webkit-ews-15 for mac-mountainlion-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: webkit-ews-15 Port: mac-mountainlion-wk2 Platform: Mac OS X 10.8.5

Created attachment 221907 [details] Patch

I think I worked it out. Mountain Lion needs specific results. No need for review.

Attachment 221907 [details] did not pass style-queue: ERROR: Source/WebCore/CMakeLists.txt:2669: Alphabetical sorting problem. "platform/text/TextCodecICU.cpp" should be before "platform/text/icu/UTextProviderUTF16.cpp". [list/order] [5] ERROR: Source/WebCore/platform/graphics/opengl/GraphicsContext3DOpenGL.cpp:355: Wrong number of spaces before statement. (expected: 12) [whitespace/indent] [4] ERROR: Source/WebCore/platform/graphics/opengl/GraphicsContext3DOpenGL.cpp:355: Wrong number of spaces before statement. (expected: 12) [whitespace/indent] [4] ERROR: Source/WebCore/platform/graphics/opengl/GraphicsContext3DOpenGL.cpp:355: Wrong number of spaces before statement. (expected: 8) [whitespace/indent] [4] ERROR: Source/WebCore/platform/graphics/opengl/GraphicsContext3DOpenGL.cpp:355: Wrong number of spaces before statement. (expected: 8) [whitespace/indent] [4] ERROR: Source/WebCore/platform/graphics/GraphicsContext3D.h:428: enum members should use InterCaps with an initial capital letter. [readability/enum_casing] [4] ERROR: Source/WebCore/platform/graphics/GraphicsContext3D.h:429: enum members should use InterCaps with an initial capital letter. [readability/enum_casing] [4] Total errors found: 7 in 27 files If any of these errors are false positives, please file a bug against check-webkit-style.

Comment on attachment 221899 [details] Patch Attachment 221899 [details] did not pass mac-ews (mac): Output: http://webkit-queues.appspot.com/results/6093500286238720 New failing tests: fast/canvas/webgl/angle-instanced-arrays.html

Created attachment 221910 [details] Archive of layout-test-results from webkit-ews-07 for mac-mountainlion The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: webkit-ews-07 Port: mac-mountainlion Platform: Mac OS X 10.8.5

Committed r162565: <http://trac.webkit.org/changeset/162565>