Bug 113351

Summary: [CSS Grid Layout] Before / start paddings and borders are not accounted for when placing the grid items
Product: WebKit Reporter: Julien Chaffraix <jchaffraix>
Component: Layout and RenderingAssignee: Julien Chaffraix <jchaffraix>
Status: RESOLVED FIXED    
Severity: Normal CC: eric, esprehn+autocc, ojan.autocc, ojan, tony, webkit.review.bot, xan.lopez
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Bug Depends on:    
Bug Blocks: 60731    
Attachments:
Description Flags
Test case, there should be some grey above and left of the colored squares
none
Proposed fix 1: Add the borders and paddings before / start. none

Julien Chaffraix
Reported Wednesday, March 27, 2013 12:03:42 AM UTC
Putting the following on the grid container (grid element before): padding: 20px; doesn't add the top and left padding (see test case).
Attachments
Test case, there should be some grey above and left of the colored squares (639 bytes, text/html)
2013-03-26 21:04 PDT, Julien Chaffraix 		no flags
Details
Proposed fix 1: Add the borders and paddings before / start. (27.94 KB, patch)
2013-03-27 20:10 PDT, Julien Chaffraix 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Julien Chaffraix
Comment 1 Wednesday, March 27, 2013 5:03:46 AM UTC
I misinterpreted the issue. The grid container is properly sized but the grid items ignore any paddings (and probably borders).
Julien Chaffraix
Comment 2 Wednesday, March 27, 2013 5:04:23 AM UTC
Created attachment 195216 [details] Test case, there should be some grey above and left of the colored squares
Julien Chaffraix
Comment 3 Thursday, March 28, 2013 4:10:13 AM UTC
Created attachment 195468 [details] Proposed fix 1: Add the borders and paddings before / start.
WebKit Review Bot
Comment 4 Thursday, March 28, 2013 8:22:20 PM UTC
Comment on attachment 195468 [details] Proposed fix 1: Add the borders and paddings before / start. Clearing flags on attachment: 195468 Committed r147140: <http://trac.webkit.org/changeset/147140>
WebKit Review Bot
Comment 5 Thursday, March 28, 2013 8:22:23 PM UTC
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.