Bug 110345

Summary: [WK2][EFL] Move PageViewportController and PageViewportControllerClientEfl out from WebView
Product: WebKit Reporter: Mikhail Pozdnyakov <mikhail.pozdnyakov>
Component: WebKit EFLAssignee: Mikhail Pozdnyakov <mikhail.pozdnyakov>
Status: RESOLVED FIXED    
Severity: Normal CC: andersca, benjamin, cmarcelo, gyuyoung.kim, kenneth, kling, lucas.de.marchi, rakuco, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 107657, 107662    
Attachments:
Description Flags
patch none

Mikhail Pozdnyakov
Reported 2013-02-20 06:56:14 PST
SSIA. WebView does not need to know about both PageViewportController and PageViewportControllerClientEfl. Considering the fact that PageViewportController will stop being WK2 internal and will be based on WK2 C API, it's worth moving it to Ewk API layer - into EwkView.
Attachments
patch (8.74 KB, patch)
2013-02-20 07:45 PST, Mikhail Pozdnyakov 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Mikhail Pozdnyakov
Comment 1 2013-02-20 07:45:39 PST
Created attachment 189318 [details] patch
Kenneth Rohde Christiansen
Comment 2 2013-02-20 08:04:58 PST
Comment on attachment 189318 [details] patch View in context: https://bugs.webkit.org/attachment.cgi?id=189318&action=review LGTM > Source/WebKit2/UIProcess/efl/WebView.cpp:155 > + m_ewkView->pageViewportControllerClient()->updateViewportSize(); Would be nice to get rid of m_ewkView from this class
Mikhail Pozdnyakov
Comment 3 2013-02-20 23:12:23 PST
(In reply to comment #2) > (From update of attachment 189318 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=189318&action=review > > LGTM > > > Source/WebKit2/UIProcess/efl/WebView.cpp:155 > > + m_ewkView->pageViewportControllerClient()->updateViewportSize(); > > Would be nice to get rid of m_ewkView from this class Sure. We'll remove m_ewkView usage here via WKViewClient API extension.
WebKit Review Bot
Comment 4 2013-02-21 04:00:34 PST
Comment on attachment 189318 [details] patch Clearing flags on attachment: 189318 Committed r143582: <http://trac.webkit.org/changeset/143582>
WebKit Review Bot
Comment 5 2013-02-21 04:00:39 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.