Bug 108901

Summary: Adds the WebGL Conformance Tests attrib folder.
Product: WebKit Reporter: Gregg Tavares <gman>
Component: WebGLAssignee: Gregg Tavares <gman>
Status: RESOLVED FIXED    
Severity: Normal CC: falken, kadam, kbr, roger_fong
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Bug Depends on:    
Bug Blocks: 94643    
Attachments:
Description Flags
Patch
none
Patch
none
Patch
none
Patch
none
Patch none

Gregg Tavares
Reported 2013-02-04 21:40:30 PST
Adds the WebGL Conformance Tests attrib folder.
Attachments
Patch (52.71 KB, patch)
2013-02-04 21:40 PST, Gregg Tavares 		no flags
DetailsFormatted DiffDiff
Patch (52.71 KB, patch)
2013-02-05 11:56 PST, Gregg Tavares 		no flags
DetailsFormatted DiffDiff
Patch (52.71 KB, patch)
2013-02-05 13:14 PST, Gregg Tavares 		no flags
DetailsFormatted DiffDiff
Patch (52.71 KB, patch)
2013-02-05 23:38 PST, Gregg Tavares 		no flags
DetailsFormatted DiffDiff
Patch (52.74 KB, patch)
2013-02-05 23:42 PST, Gregg Tavares 		no flags
DetailsFormatted DiffDiff
Show Obsolete (5) View All Add attachment proposed patch, testcase, etc.
Gregg Tavares
Comment 1 2013-02-04 21:40:48 PST
Created attachment 186542 [details] Patch
Kenneth Russell
Comment 2 2013-02-05 10:26:58 PST
Comment on attachment 186542 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=186542&action=review This is fantastic. One minor issue. r=me > LayoutTests/platform/chromium/TestExpectations:1434 > +crbug.com/172368 webgl/conformance/attribs/gl-vertex-attrib-zero-issues.html [ Skip ] This isn't the correct bug ID. Could you update it?
Gregg Tavares
Comment 3 2013-02-05 11:56:02 PST
Created attachment 186670 [details] Patch
Gregg Tavares
Comment 4 2013-02-05 13:14:06 PST
Created attachment 186689 [details] Patch
Gregg Tavares
Comment 5 2013-02-05 23:38:21 PST
Created attachment 186765 [details] Patch
Gregg Tavares
Comment 6 2013-02-05 23:42:17 PST
Created attachment 186768 [details] Patch
Gregg Tavares
Comment 7 2013-02-05 23:42:59 PST
Committed r141971: <http://trac.webkit.org/changeset/141971>
Ádám Kallai
Comment 8 2013-02-06 01:15:54 PST
Three webgl tests fail on Qt. The last one landed in r141911. Do you have any idea? Thanks. * webgl/conformance/attribs/gl-vertex-attrib-render.html --- /ramdisk/qt-linux-64-release/build/layout-test-results/webgl/conformance/attribs/gl-vertex-attrib-render-expected.txt +++ /ramdisk/qt-linux-64-release/build/layout-test-results/webgl/conformance/attribs/gl-vertex-attrib-render-actual.txt @@ -1,5 +1,5 @@ This test runs the WebGL Test listed below in an iframe and reports PASS or FAIL. Test: ../../resources/webgl_test_files/conformance/attribs/gl-vertex-attrib-render.html -PASS +FAIL * webgl/conformance/attribs/gl-vertexattribpointer-offsets.html --- /ramdisk/qt-linux-64-release/build/layout-test-results/webgl/conformance/attribs/gl-vertexattribpointer-offsets-expected.txt +++ /ramdisk/qt-linux-64-release/build/layout-test-results/webgl/conformance/attribs/gl-vertexattribpointer-offsets-actual.txt @@ -1,5 +1,5 @@ This test runs the WebGL Test listed below in an iframe and reports PASS or FAIL. Test: ../../resources/webgl_test_files/conformance/attribs/gl-vertexattribpointer-offsets.html -PASS +FAIL * webgl/conformance/misc/delayed-drawing.html --- /ramdisk/qt-linux-64-release/build/layout-test-results/webgl/conformance/misc/delayed-drawing-expected.txt +++ /ramdisk/qt-linux-64-release/build/layout-test-results/webgl/conformance/misc/delayed-drawing-actual.txt @@ -1,5 +1,5 @@ This test runs the WebGL Test listed below in an iframe and reports PASS or FAIL. Test: ../../resources/webgl_test_files/conformance/misc/delayed-drawing.html -PASS +FAIL
Ádám Kallai
Comment 9 2013-02-06 06:44:52 PST
I forgot something: stderr contains: "failed to create drawable." By the way WebGL is disabled on Qt so webgl tests shouldn't be run.
Gregg Tavares
Comment 10 2013-02-06 09:10:33 PST
Sorry about that. This patch is supposed to make it skip ports that don't support WebGL. Any idea why this isn't working for qt?
Gregg Tavares
Comment 11 2013-02-06 09:10:53 PST
(In reply to comment #10) > Sorry about that. > > This patch is supposed to make it skip ports that don't support WebGL. Oops: https://bugs.webkit.org/show_bug.cgi?id=108705 > > Any idea why this isn't working for qt?
Roger Fong
Comment 12 2013-02-06 15:34:44 PST
Hi do you mind adding any webgl tests in to the Windows skip list? LayoutTests/platform/win/TestExpectations There should be a section with disabled webgl tests. I've added some of the recently added conformance tests to it but it looks like there are sitll more rolling in. http://build.webkit.org/results/Apple%20Win%207%20Release%20(Tests)/r141971%20(32095)/results.html Could you skip those and any future webgl-conformance tests added? Thanks
Gregg Tavares
Comment 13 2013-02-06 15:59:57 PST
Do you need all WebGL tests disabled in Windows or just the tests that fail on mac?
Roger Fong
Comment 14 2013-02-06 16:04:18 PST
All of em! WebGL isn't implement on the Apple Windows port :(... Thanks again!
Matt Falkenhagen
Comment 15 2013-02-06 18:32:40 PST
gl-vertexattribpointer.html is timing out on Debug Chromium bots. I'll mark it in TestExpectations. http://test-results.appspot.com/dashboards/flakiness_dashboard.html#group=%40ToT%20-%20chromium.org&tests=webgl%2Fconformance%2Fattribs%2Fgl-vertexattribpointer.html
Gregg Tavares
Comment 16 2013-02-06 18:34:58 PST
(In reply to comment #15) > gl-vertexattribpointer.html is timing out on Debug Chromium bots. I'll mark it in TestExpectations. > > http://test-results.appspot.com/dashboards/flakiness_dashboard.html#group=%40ToT%20-%20chromium.org&tests=webgl%2Fconformance%2Fattribs%2Fgl-vertexattribpointer.html can you mark it as slow? It is a slow test.
Matt Falkenhagen
Comment 17 2013-02-06 18:54:04 PST
(In reply to comment #16) > can you mark it as slow? It is a slow test. Done!
Eric Seidel (no email)
Comment 18 2013-03-01 02:52:17 PST
Comment on attachment 186768 [details] Patch Cleared review? from attachment 186768 [details] so that this bug does not appear in http://webkit.org/pending-review. If you would like this patch reviewed, please attach it to a new bug (or re-open this bug before marking it for review again).
Note You need to log in before you can comment on or make changes to this bug.