Bug 107175
| Summary: | [Chromium] Incorrect |isRedirect| value passed to decidePolicyForNavigation | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Marshall Greenblatt <marshall> |
| Component: | Page Loading | Assignee: | Nobody <webkit-unassigned> |
| Status: | RESOLVED WONTFIX | ||
| Severity: | Normal | CC: | fddima, japhet, schenney |
| Priority: | P2 | ||
| Version: | 528+ (Nightly build) | ||
| Hardware: | All | ||
| OS: | All | ||
Marshall Greenblatt
Chromium revision 176706
WebKit revision 139548
1. Load an application that uses the Chromium WebKit API.
2. Redirect a request via net::URLRequestJob::IsRedirectResponse by populating |location| and returning true.
The |isRedirect| value passed to WebFrameClient::decidePolicyForNavigation in FrameLoaderClientImpl::dispatchDecidePolicyForNavigationAction should be true. However, WebKit revision 137607 (http://trac.webkit.org/changeset/137607) changed the implementation of MainResourceLoader::load() such that WebDataSourceImpl::appendRedirect() is no longer called for the redirected URL following this code path. As a result the |isRedirect| value is now false.
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Nate Chapin
(In reply to comment #0)
> Chromium revision 176706
> WebKit revision 139548
>
> 1. Load an application that uses the Chromium WebKit API.
> 2. Redirect a request via net::URLRequestJob::IsRedirectResponse by populating |location| and returning true.
>
> The |isRedirect| value passed to WebFrameClient::decidePolicyForNavigation in FrameLoaderClientImpl::dispatchDecidePolicyForNavigationAction should be true. However, WebKit revision 137607 (http://trac.webkit.org/changeset/137607) changed the implementation of MainResourceLoader::load() such that WebDataSourceImpl::appendRedirect() is no longer called for the redirected URL following this code path. As a result the |isRedirect| value is now false.
At a quick glance, this is probably because the timing of the call to dispatchDidReceiveServerRedirectForProvisionalLoad() changed.
Marshall Greenblatt
Moved to Blink as https://code.google.com/p/chromium/issues/detail?id=229154.