Bug 102665

Created attachment 175410 [details] WIP patch

Created attachment 205071 [details] Testcase for caret movement Place the cursor at the middle of the vertically aligned text. Try to insert a line break/paragraph and that point or try to move the caret using the arrow keys. Notice how the expected behavior is visible only after a repaint occurs on the page. The root editing element in this case is again positioned; either absolute or fixed.

Comment on attachment 205071 [details] Testcase for caret movement Incorrect test case

Created attachment 205072 [details] Testcase for caret movement Place the cursor at the middle of the vertically aligned text. Try to insert a line break/paragraph and that point or try to move the caret using the arrow keys. Notice how the expected behavior is visible only after a repaint occurs on the page. The root editing element in this case is again positioned; either absolute or fixed.

Created attachment 205469 [details] Patch

Comment on attachment 205469 [details] Patch Attachment 205469 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.appspot.com/results/916668 New failing tests: editing/inserting/insert-paragraph-between-vertical-text-with-positioned-root.html

Created attachment 205486 [details] Archive of layout-test-results from webkit-ews-10 for mac-mountainlion-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: webkit-ews-10 Port: mac-mountainlion-wk2 Platform: Mac OS X 10.8.3

Comment on attachment 205469 [details] Patch Attachment 205469 [details] did not pass mac-ews (mac): Output: http://webkit-queues.appspot.com/results/957178 New failing tests: editing/inserting/insert-paragraph-between-vertical-text-with-positioned-root.html

Created attachment 205490 [details] Archive of layout-test-results from webkit-ews-08 for mac-mountainlion The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: webkit-ews-08 Port: mac-mountainlion Platform: Mac OS X 10.8.3

Comment on attachment 205469 [details] Patch Attachment 205469 [details] did not pass win-ews (win): Output: http://webkit-queues.appspot.com/results/967294 New failing tests: editing/inserting/insert-paragraph-between-vertical-text-with-positioned-root.html

Created attachment 205494 [details] Archive of layout-test-results from APPLE-EWS-1 for win-future The attached test failures were seen while running run-webkit-tests on the win-ews. Bot: APPLE-EWS-1 Port: win-future Platform: CYGWIN_NT-6.1-WOW64-1.7.20-0.266-5-3-i686-32bit

Comment on attachment 205469 [details] Patch Attachment 205469 [details] did not pass win-ews (win): Output: http://webkit-queues.appspot.com/results/919243 New failing tests: editing/inserting/insert-paragraph-between-vertical-text-with-positioned-root.html

Created attachment 205505 [details] Archive of layout-test-results from APPLE-EWS-3 for win-future The attached test failures were seen while running run-webkit-tests on the win-ews. Bot: APPLE-EWS-3 Port: win-future Platform: CYGWIN_NT-6.1-WOW64-1.7.20-0.266-5-3-i686-32bit

Created attachment 205564 [details] Patch

Comment on attachment 205564 [details] Patch Attachment 205564 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.appspot.com/results/993112 New failing tests: editing/inserting/insert-paragraph-between-vertical-text-with-positioned-root.html

Created attachment 205568 [details] Archive of layout-test-results from webkit-ews-15 for mac-mountainlion-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: webkit-ews-15 Port: mac-mountainlion-wk2 Platform: Mac OS X 10.8.3

Comment on attachment 205564 [details] Patch Attachment 205564 [details] did not pass mac-ews (mac): Output: http://webkit-queues.appspot.com/results/987201 New failing tests: editing/inserting/insert-paragraph-between-vertical-text-with-positioned-root.html

Created attachment 205577 [details] Archive of layout-test-results from webkit-ews-03 for mac-mountainlion The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: webkit-ews-03 Port: mac-mountainlion Platform: Mac OS X 10.8.3

Comment on attachment 205564 [details] Patch Attachment 205564 [details] did not pass win-ews (win): Output: http://webkit-queues.appspot.com/results/976253 New failing tests: editing/inserting/insert-paragraph-between-vertical-text-with-positioned-root.html

Created attachment 205591 [details] Archive of layout-test-results from APPLE-EWS-5 for win-future The attached test failures were seen while running run-webkit-tests on the win-ews. Bot: APPLE-EWS-5 Port: win-future Platform: CYGWIN_NT-6.1-WOW64-1.7.20-0.266-5-3-i686-32bit

Comment on attachment 205564 [details] Patch Attachment 205564 [details] did not pass win-ews (win): Output: http://webkit-queues.appspot.com/results/972637 New failing tests: editing/inserting/insert-paragraph-between-vertical-text-with-positioned-root.html

Created attachment 205597 [details] Archive of layout-test-results from APPLE-EWS-1 for win-future The attached test failures were seen while running run-webkit-tests on the win-ews. Bot: APPLE-EWS-1 Port: win-future Platform: CYGWIN_NT-6.1-WOW64-1.7.20-0.266-5-3-i686-32bit

Comment on attachment 205564 [details] Patch Attachment 205564 [details] did not pass win-ews (win): Output: http://webkit-queues.appspot.com/results/997104 New failing tests: editing/inserting/insert-paragraph-between-vertical-text-with-positioned-root.html

Created attachment 205605 [details] Archive of layout-test-results from APPLE-EWS-3 for win-future The attached test failures were seen while running run-webkit-tests on the win-ews. Bot: APPLE-EWS-3 Port: win-future Platform: CYGWIN_NT-6.1-WOW64-1.7.20-0.266-5-3-i686-32bit

Hey Zalan, Following are the repaint rects on mac: (repaint rects (rect -46 201 32 300) (rect 2 200 202 302) (rect 155 409 16 1) (rect 155 409 16 1) (rect 155 409 16 1) (rect 155 393 16 1) (rect -46 201 32 300) (rect 155 393 16 1) (rect 155 409 16 1) (rect 155 409 16 1) (rect 155 393 16 1) (rect 155 201 32 300) (rect -46 201 32 300) (rect 155 201 32 300) (rect 155 201 32 300) (rect -46 201 32 300) (rect -30 201 16 300) (rect 107 393 16 1) (rect 123 201 16 1) ) and following are on qt: (repaint rects (rect -33 201 19 300) (rect 2 200 202 302) (rect 168 384 19 1) (rect 168 384 19 1) (rect 168 384 19 1) (rect 168 375 19 1) (rect -33 201 19 300) (rect 168 375 19 1) (rect 168 384 19 1) (rect 168 384 19 1) (rect 168 375 19 1) (rect 168 201 19 300) (rect -33 201 19 300) (rect 168 201 19 300) (rect 168 201 19 300) (rect -33 201 19 300) (rect -33 201 19 300) (rect 133 375 19 1) (rect 133 201 19 1) )

Comment on attachment 205564 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=205564&action=review > LayoutTests/editing/inserting/insert-paragraph-between-vertical-text-with-positioned-root.html:18 > + font-family: Ahem; You should specify the font size by px here.

Created attachment 205890 [details] Patch

(In reply to comment #26) > (From update of attachment 205564 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=205564&action=review > > > LayoutTests/editing/inserting/insert-paragraph-between-vertical-text-with-positioned-root.html:18 > > + font-family: Ahem; > > You should specify the font size by px here. Hi Ryosuke, thanks for the tip! Have uploaded another patch specifying the font-size and line-height as well.

+enrica.

Comment on attachment 205890 [details] Patch Assuming that patches for review since 2013 are stale, r-

Created attachment 280344 [details] Patch

Comment on attachment 280344 [details] Patch Attachment 280344 [details] did not pass mac-ews (mac): Output: http://webkit-queues.webkit.org/results/1424532 New failing tests: fast/repaint/vertical-text-repaint.html

Created attachment 280352 [details] Archive of layout-test-results from ews102 for mac-yosemite The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: ews102 Port: mac-yosemite Platform: Mac OS X 10.10.5

Comment on attachment 280344 [details] Patch Attachment 280344 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.webkit.org/results/1424538 New failing tests: svg/animations/smil-leak-element-instances.svg

Created attachment 280353 [details] Archive of layout-test-results from ews107 for mac-yosemite-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: ews107 Port: mac-yosemite-wk2 Platform: Mac OS X 10.10.5

Comment on attachment 280344 [details] Patch Attachment 280344 [details] did not pass mac-debug-ews (mac): Output: http://webkit-queues.webkit.org/results/1424547 New failing tests: fast/repaint/vertical-text-repaint.html

Created attachment 280354 [details] Archive of layout-test-results from ews113 for mac-yosemite The attached test failures were seen while running run-webkit-tests on the mac-debug-ews. Bot: ews113 Port: mac-yosemite Platform: Mac OS X 10.10.5

Comment on attachment 280344 [details] Patch r=me, make sure you figure out layout tests.

Created attachment 280399 [details] Patch

Checking repaint rects on EWS.

Comment on attachment 280399 [details] Patch Attachment 280399 [details] did not pass mac-ews (mac): Output: http://webkit-queues.webkit.org/results/1426066 New failing tests: fast/repaint/vertical-text-repaint.html

Created attachment 280410 [details] Archive of layout-test-results from ews102 for mac-yosemite The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: ews102 Port: mac-yosemite Platform: Mac OS X 10.10.5

Comment on attachment 280399 [details] Patch Attachment 280399 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.webkit.org/results/1426071 New failing tests: fast/repaint/vertical-text-repaint.html

Created attachment 280413 [details] Archive of layout-test-results from ews107 for mac-yosemite-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: ews107 Port: mac-yosemite-wk2 Platform: Mac OS X 10.10.5

Comment on attachment 280399 [details] Patch Attachment 280399 [details] did not pass mac-debug-ews (mac): Output: http://webkit-queues.webkit.org/results/1426074 New failing tests: fast/repaint/vertical-text-repaint.html

Created attachment 280419 [details] Archive of layout-test-results from ews115 for mac-yosemite The attached test failures were seen while running run-webkit-tests on the mac-debug-ews. Bot: ews115 Port: mac-yosemite Platform: Mac OS X 10.10.5

Created attachment 280422 [details] Patch

Comment on attachment 280422 [details] Patch Clearing flags on attachment: 280422 Committed r201635: <http://trac.webkit.org/changeset/201635>

All reviewed patches have been landed. Closing bug.

Reopening to attach new patch.

Created attachment 280567 [details] Patch

Attachment 280567 [details] did not pass style-queue: ERROR: Source/WebCore/ChangeLog:1: ChangeLog entry has no bug number [changelog/bugnumber] [5] Total errors found: 1 in 7 files If any of these errors are false positives, please file a bug against check-webkit-style.

Comment on attachment 280567 [details] Patch Clearing flags on attachment: 280567 Committed r201704: <http://trac.webkit.org/changeset/201704>

All reviewed patches have been landed. Closing bug.

*** Bug 157571 has been marked as a duplicate of this bug. ***