Bug 100995

Summary: [Qt][Mac][Win] r133182 broke the build
Product: WebKit Reporter: Nandor Huszka <hnandor>
Component: New BugsAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Blocker CC: dongseong.hwang, gustavo, noam, ossy, philn, xan.lopez
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 100907    
Attachments:
Description Flags
proposed patch
webkit-ews: commit-queue-
proposed patch
buildbot: commit-queue-
proposed patch none

Nandor Huszka
Reported 2012-11-01 15:19:31 PDT
c:\webkitbuildslave\szeged-windows-1\qt-windows-32bit-release\build\source\webkit2\webprocess\webpage\coordinatedgraphics\CoordinatedGraphicsLayer.h(116) : error C3668: 'WebCore::CoordinatedGraphicsLayer::setContentsScale' : method with override specifier 'override' did not override any base class methods c:\webkitbuildslave\szeged-windows-1\qt-windows-32bit-release\build\source\webkit2\webprocess\webpage\coordinatedgraphics\CoordinatedGraphicsLayer.h(117) : error C3668: 'WebCore::CoordinatedGraphicsLayer::setVisibleContentRectTrajectoryVector' : method with override specifier 'override' did not override any base class methods
Attachments
proposed patch (1.38 KB, patch)
2012-11-01 15:23 PDT, Nandor Huszka 		webkit-ews: commit-queue-
DetailsFormatted DiffDiff
proposed patch (1.39 KB, patch)
2012-11-01 15:57 PDT, Nandor Huszka 		buildbot: commit-queue-
DetailsFormatted DiffDiff
proposed patch (2.06 KB, patch)
2012-11-02 01:06 PDT, Nandor Huszka 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Nandor Huszka
Comment 1 2012-11-01 15:23:13 PDT
Created attachment 171943 [details] proposed patch
Early Warning System Bot
Comment 2 2012-11-01 15:47:53 PDT
Comment on attachment 171943 [details] proposed patch Attachment 171943 [details] did not pass qt-ews (qt): Output: http://queues.webkit.org/results/14686645
Nandor Huszka
Comment 3 2012-11-01 15:57:47 PDT
Created attachment 171947 [details] proposed patch Fix pure virtual problem.
Build Bot
Comment 4 2012-11-01 16:30:05 PDT
Comment on attachment 171947 [details] proposed patch Attachment 171947 [details] did not pass mac-ews (mac): Output: http://queues.webkit.org/results/14656691
Dongseong Hwang
Comment 5 2012-11-01 16:31:42 PDT
Thanks for reporting and patch. Who broke build is me. I think we should not add this API in GraphicLayer. I made a mistake to put virtual and OVERRIDE to two methods in CoordinatedGraphicsLayer. virtual void setContentsScale(float) OVERRIDE; virtual void setVisibleContentRectTrajectoryVector(const FloatPoint&) OVERRIDE; How about removing virtual and OVERRIDE from two methods in CoordinatedGraphicsLayer like this. void setContentsScale(float); void setVisibleContentRectTrajectoryVector(const FloatPoint&); I need two methods position in header file is also changed, because two methods mix with overrided methods of GraphicsLayer. Could you do that?
Nandor Huszka
Comment 6 2012-11-02 00:37:11 PDT
(In reply to comment #5) > Thanks for reporting and patch. Who broke build is me. > > I think we should not add this API in GraphicLayer. > > I made a mistake to put virtual and OVERRIDE to two methods in CoordinatedGraphicsLayer. > virtual void setContentsScale(float) OVERRIDE; > virtual void setVisibleContentRectTrajectoryVector(const FloatPoint&) OVERRIDE; > > How about removing virtual and OVERRIDE from two methods in CoordinatedGraphicsLayer like this. > void setContentsScale(float); > void setVisibleContentRectTrajectoryVector(const FloatPoint&); > > I need two methods position in header file is also changed, because two methods mix with overrided methods of GraphicsLayer. > > Could you do that? Thank you for the tip, of course I will do that. Unfortunately I chose the wrong way of fixing first. Now I see that other platforms do not need these methods.
Nandor Huszka
Comment 7 2012-11-02 01:06:56 PDT
Created attachment 172001 [details] proposed patch
Dongseong Hwang
Comment 8 2012-11-02 01:40:52 PDT
(In reply to comment #7) > Created an attachment (id=172001) [details] > proposed patch Thanks. LGTM! :)
Csaba Osztrogonác
Comment 9 2012-11-02 02:16:33 PDT
Comment on attachment 172001 [details] proposed patch Clearing flags on attachment: 172001 Committed r133276: <http://trac.webkit.org/changeset/133276>
Csaba Osztrogonác
Comment 10 2012-11-02 02:16:39 PDT
All reviewed patches have been landed. Closing bug.
Darin Adler
Comment 11 2012-11-02 15:57:38 PDT
Comment on attachment 172001 [details] proposed patch View in context: https://bugs.webkit.org/attachment.cgi?id=172001&action=review > Source/WebKit2/WebProcess/WebPage/CoordinatedGraphics/CoordinatedGraphicsLayer.h:126 > + virtual void setContentsScale(float); > + virtual void setVisibleContentRectTrajectoryVector(const FloatPoint&); The change log said you’d remove the virtual as well as OVERRIDE, but the patch removes OVERRIDE but leaves virtual in!
Dongseong Hwang
Comment 12 2012-11-02 20:51:09 PDT
(In reply to comment #11) > (From update of attachment 172001 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=172001&action=review > > > Source/WebKit2/WebProcess/WebPage/CoordinatedGraphics/CoordinatedGraphicsLayer.h:126 > > + virtual void setContentsScale(float); > > + virtual void setVisibleContentRectTrajectoryVector(const FloatPoint&); > > The change log said you’d remove the virtual as well as OVERRIDE, but the patch removes OVERRIDE but leaves virtual in! Thanks. I filed Bug 101141.
Nandor Huszka
Comment 13 2012-11-03 04:13:42 PDT
(In reply to comment #11) > The change log said you’d remove the virtual as well as OVERRIDE, but the patch removes OVERRIDE but leaves virtual in! I forgot to delete it too, thank you for the remark!
Note You need to log in before you can comment on or make changes to this bug.