Bug 251346 - Unnecessarily using std::variant and std::monostate when we could just use nullptr instead
Summary: Unnecessarily using std::variant and std::monostate when we could just use nu...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (show other bugs)
Version: WebKit Nightly Build
Hardware: All All
: P2 Normal
Assignee: Darin Adler
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2023-01-29 22:18 PST by Darin Adler
Modified: 2023-01-30 11:01 PST (History)
3 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Darin Adler 2023-01-29 22:18:17 PST 
Noticed that some code is using std::variant and std::monostate for a case where nullptr will do the trick.
Comment 1 Radar WebKit Bug Importer 2023-01-29 22:19:09 PST 
<rdar://problem/104809022>
Comment 2 Darin Adler 2023-01-29 23:37:36 PST 
Pull request: https://github.com/WebKit/WebKit/pull/9302
Comment 3 EWS 2023-01-30 11:01:02 PST 
Committed 259572@main (37f282e65d2e): <https://commits.webkit.org/259572@main>

Reviewed commits have been landed. Closing PR #9302 and removing active labels.