RESOLVED FIXED251222
[ews] Run ValidateChange just before CompileWebKit and major steps 
https://bugs.webkit.org/show_bug.cgi?id=251222
Summary [ews] Run ValidateChange just before CompileWebKit and major steps
Aakash Jain
Reported 2023-01-26 12:34:16 PST
EWS builds should run ValidateChange just after completing all the checkout operations. This becomes more important because of skip-ews support. When using git-webkit pr --no-ews, skip-ews label is added by our tooling slightly after the PR creation. It races with build starting on bots, and builds can start (and pass the ValidateChange step which happens in the beginning of the build) before skip-ews label was added by the tooling. Since git operations like CleanGitRepo, CheckOutSource, CheckOutPullRequest takes few minutes, we should do the validation after those steps as well.
Attachments
Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2023-01-26 13:28:29 PST
<rdar://problem/104710968>
Aakash Jain
Comment 2 2023-01-26 13:39:44 PST
Pull request: https://github.com/WebKit/WebKit/pull/9187
Aakash Jain
Comment 3 2023-01-27 05:12:36 PST
Discussed with Jonathan. We also want to be conscious of number of api calls we make to GitHub as we might hit the api limit. Changed it to run ValidateChange just before CompileWebKit and major steps.
EWS
Comment 4 2023-01-27 09:17:01 PST
Committed 259493@main (3808d4657839): <https://commits.webkit.org/259493@main> Reviewed commits have been landed. Closing PR #9187 and removing active labels.
Note You need to log in before you can comment on or make changes to this bug.