Bug 251130 - OffscreenCanvas::transferToImageBitmap doesn't restrict enforce size restrictions
Summary: OffscreenCanvas::transferToImageBitmap doesn't restrict enforce size restrict...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Canvas (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Matt Woodrow
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2023-01-24 20:27 PST by Matt Woodrow
Modified: 2023-02-08 14:16 PST (History)
2 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Matt Woodrow 2023-01-24 20:27:58 PST 
We share code with HTMLCanvasElement via CanvasBase for allocating the backing store, with max size restrictions.

transferToImageBitmap can sometimes allocate a new buffer (if there isn't one already), and it currently isn't using the same code, so doesn't have the same restrictions.
Comment 1 Matt Woodrow 2023-01-24 20:28:18 PST 
<rdar://104298886>
Comment 2 Matt Woodrow 2023-01-24 20:30:34 PST 
Pull request: https://github.com/WebKit/WebKit/pull/9088
Comment 3 EWS 2023-02-08 14:16:04 PST 
Committed 260035@main (e4c57c810933): <https://commits.webkit.org/260035@main>

Reviewed commits have been landed. Closing PR #9088 and removing active labels.