Bug 251103 - Autogenerated settings turn off too many things in Lockdown Mode
Summary: Autogenerated settings turn off too many things in Lockdown Mode
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Misc. (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Brent Fulgham
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2023-01-24 12:25 PST by Brent Fulgham
Modified: 2023-01-24 19:06 PST (History)
1 user (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Brent Fulgham 2023-01-24 12:25:56 PST 
We decided that 'developer' state should refer to features that are usually off, and might be enabled by developers debugging a problem. A number of features that are expected to be enabled at all times were labeled with this state, causing our LDM logic to turn them off.

Instead, we should use 'stable' for features that developers may wish to turn off for A/B reasons, but are not intended to be off for most use cases.

This patch corrects these problems, and exposes two WebRTC flags as developer options that can be enabled for experimentation, but should not be used by default.
Comment 1 Brent Fulgham 2023-01-24 12:27:58 PST 
<rdar://104482701>
Comment 2 Brent Fulgham 2023-01-24 12:31:55 PST 
Pull request: https://github.com/WebKit/WebKit/pull/9063
Comment 3 EWS 2023-01-24 19:06:51 PST 
Committed 259331@main (fb16e152e4f6): <https://commits.webkit.org/259331@main>

Reviewed commits have been landed. Closing PR #9063 and removing active labels.