Bug 251100 - Table cells, rows, sections or column (groups) don't support margins
Summary: Table cells, rows, sections or column (groups) don't support margins
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2023-01-24 11:15 PST by Ahmad Saleem
Modified: 2023-02-07 03:05 PST (History)
5 users (show)

See Also:

Attachments
test for margin on tables element (977 bytes, text/html)
2023-01-24 18:58 PST, Karl Dubost 		no flags Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Ahmad Saleem 2023-01-24 11:15:05 PST 
Hi Team,

While going through Blink's commit, I came across this commit, which fixes FIXME, which is still present in WebKit:

Blink Commit - https://src.chromium.org/viewvc/blink?revision=197770&view=revision

WebKit Source - https://searchfox.org/wubkat/source/Source/WebCore/rendering/RenderBox.cpp#3690 & https://searchfox.org/wubkat/source/Source/WebCore/rendering/RenderTableRow.cpp#151

Just wanted to raise and check if we have any plan to address FIXME as part of new layout refactoring or for time being we can merge this.

Thanks!
Comment 1 Karl Dubost 2023-01-24 18:58:33 PST 
Created attachment 464641 [details]
test for margin on tables element

Probably there should be a test about this first. 
And see what it does in different browsers?

I uploaded a test case. No browsers react at all on the margin setting.
Comment 2 Radar WebKit Bug Importer 2023-01-31 11:16:17 PST 
<rdar://problem/104876500>
Comment 3 EWS 2023-02-07 03:05:38 PST 
Committed 259955@main (2c733023916d): <https://commits.webkit.org/259955@main>

Reviewed commits have been landed. Closing PR #9706 and removing active labels.