Bug 251046 - Change code order in HTMLMetaElement::process()
Summary: Change code order in HTMLMetaElement::process()
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: DOM (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2023-01-23 15:33 PST by Ahmad Saleem
Modified: 2023-01-26 00:36 PST (History)
6 users (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Ahmad Saleem 2023-01-23 15:33:40 PST
Hi Team,

While going through Blink's commits, I came across another potential merge:

Blink Commit - https://chromium.googlesource.com/chromium/blink/+/d905ef4a93adf27fc8f72cc333e28acf0e912cf6%5E%21/#F0

WebKit Source - https://searchfox.org/wubkat/source/Source/WebCore/html/HTMLMetaElement.cpp#163

```

Check the name value earlier to avoid unnecessary comparisons.

```

This is to provide early return for 'name' & 'httpEquivValue' before doing other comparisons. So I think it is kind of optimization in process.

Appreciate if someone can share input and if comment whether we can merge this without any test case.

Thanks!
Comment 1 Tim Nguyen (:ntim) 2023-01-24 15:20:01 PST
This is probably mergeable without testcase as it doesn't change behavior.

Though some function names have changed:

`fastGetAttribute` is `attributeWithoutSynchronization`

I think `AtomicString` is just `AtomString`
Comment 2 Ahmad Saleem 2023-01-24 16:00:36 PST
(In reply to Tim Nguyen (:ntim) from comment #1)
> This is probably mergeable without testcase as it doesn't change behavior.
> 
> Though some function names have changed:
> 
> `fastGetAttribute` is `attributeWithoutSynchronization`
> 
> I think `AtomicString` is just `AtomString`

Cool! Here is PR - https://github.com/WebKit/WebKit/pull/9080

Tested locally, it does compile and loading websites fine based on WebKit ToT and using --release.
Comment 3 EWS 2023-01-26 00:35:46 PST
Committed 259413@main (b66d5e5ea816): <https://commits.webkit.org/259413@main>

Reviewed commits have been landed. Closing PR #9080 and removing active labels.
Comment 4 Radar WebKit Bug Importer 2023-01-26 00:36:20 PST
<rdar://problem/104684501>