RESOLVED FIXED250982
[IFC] Rename LineBoxBuilder::adjustedLayoutBoundsWithFallbackFonts to enclosingAscentDescentWithFallbackFonts 
https://bugs.webkit.org/show_bug.cgi?id=250982
Summary [IFC] Rename LineBoxBuilder::adjustedLayoutBoundsWithFallbackFonts to enclosi...
alan
Reported 2023-01-22 08:40:44 PST
ssia
Attachments
Patch (9.96 KB, patch)
2023-01-22 08:43 PST, alan 		no flags
DetailsFormatted DiffDiff
[fast-cq]Patch (9.98 KB, patch)
2023-01-22 08:48 PST, alan 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
alan
Comment 1 2023-01-22 08:43:26 PST
Created attachment 464593 [details] Patch
Antti Koivisto
Comment 2 2023-01-22 08:45:23 PST
Comment on attachment 464593 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=464593&action=review > Source/WebCore/layout/formattingContexts/inline/InlineLineBoxBuilder.cpp:154 > +AscentAndDescent LineBoxBuilder::enclosingAscentDescentWithFallbackFonts(InlineLevelBox& inlineBox, const TextUtil::FallbackFontList& fallbackFontsForContent, FontBaseline fontBaseline) const Can this take const InlineLevelBox&?
alan
Comment 3 2023-01-22 08:46:25 PST
(In reply to Antti Koivisto from comment #2) > Comment on attachment 464593 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=464593&action=review > > > Source/WebCore/layout/formattingContexts/inline/InlineLineBoxBuilder.cpp:154 > > +AscentAndDescent LineBoxBuilder::enclosingAscentDescentWithFallbackFonts(InlineLevelBox& inlineBox, const TextUtil::FallbackFontList& fallbackFontsForContent, FontBaseline fontBaseline) const > > Can this take const InlineLevelBox&? excellent point!
alan
Comment 4 2023-01-22 08:48:23 PST
Created attachment 464594 [details] [fast-cq]Patch
EWS
Comment 5 2023-01-22 11:31:54 PST
Committed 259194@main (15e2f12c0c15): <https://commits.webkit.org/259194@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 464594 [details].
Radar WebKit Bug Importer
Comment 6 2023-01-22 11:32:19 PST
<rdar://problem/104532519>
Note You need to log in before you can comment on or make changes to this bug.