Bug 250982 - [IFC] Rename LineBoxBuilder::adjustedLayoutBoundsWithFallbackFonts to enclosingAscentDescentWithFallbackFonts
Summary: [IFC] Rename LineBoxBuilder::adjustedLayoutBoundsWithFallbackFonts to enclosi...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: zalan
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2023-01-22 08:40 PST by zalan
Modified: 2023-01-22 11:32 PST (History)
5 users (show)

See Also:

Attachments
Patch (9.96 KB, patch)
2023-01-22 08:43 PST, zalan 		no flags Details | Formatted Diff | Diff
[fast-cq]Patch (9.98 KB, patch)
2023-01-22 08:48 PST, zalan 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description zalan 2023-01-22 08:40:44 PST 
ssia
Comment 1 zalan 2023-01-22 08:43:26 PST 
Created attachment 464593 [details]
Patch
Comment 2 Antti Koivisto 2023-01-22 08:45:23 PST 
Comment on attachment 464593 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=464593&action=review

> Source/WebCore/layout/formattingContexts/inline/InlineLineBoxBuilder.cpp:154
> +AscentAndDescent LineBoxBuilder::enclosingAscentDescentWithFallbackFonts(InlineLevelBox& inlineBox, const TextUtil::FallbackFontList& fallbackFontsForContent, FontBaseline fontBaseline) const

Can this take const InlineLevelBox&?
Comment 3 zalan 2023-01-22 08:46:25 PST 
(In reply to Antti Koivisto from comment #2)
> Comment on attachment 464593 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=464593&action=review
> 
> > Source/WebCore/layout/formattingContexts/inline/InlineLineBoxBuilder.cpp:154
> > +AscentAndDescent LineBoxBuilder::enclosingAscentDescentWithFallbackFonts(InlineLevelBox& inlineBox, const TextUtil::FallbackFontList& fallbackFontsForContent, FontBaseline fontBaseline) const
> 
> Can this take const InlineLevelBox&?
excellent point!
Comment 4 zalan 2023-01-22 08:48:23 PST 
Created attachment 464594 [details]
[fast-cq]Patch
Comment 5 EWS 2023-01-22 11:31:54 PST 
Committed 259194@main (15e2f12c0c15): <https://commits.webkit.org/259194@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 464594 [details].
Comment 6 Radar WebKit Bug Importer 2023-01-22 11:32:19 PST 
<rdar://problem/104532519>