Bug 250909 - Rename hasTransform() to isTransformed() on RenderObject and RenderLayer
Summary: Rename hasTransform() to isTransformed() on RenderObject and RenderLayer
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: Safari Technology Preview
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Antoine Quint
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2023-01-20 11:57 PST by Antoine Quint
Modified: 2023-01-21 10:08 PST (History)
4 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Antoine Quint 2023-01-20 11:57:19 PST 
The name "hasTransform" is kind of convoluted in WebCore due to historically denoting on RenderStyle whether a "transform" property was set to some non-none value. With the addition of more CSS properties affecting transform, and the addition of RenderStyle::affectsTransform(), we should also rename "hasTransform" on RenderLayer and RenderObject to be "isTransformed" to better match what this method denotes.
Comment 1 Antoine Quint 2023-01-20 11:59:17 PST 
Pull request: https://github.com/WebKit/WebKit/pull/8886
Comment 2 EWS 2023-01-21 09:21:06 PST 
Committed 259171@main (c934d4911662): <https://commits.webkit.org/259171@main>

Reviewed commits have been landed. Closing PR #8886 and removing active labels.
Comment 3 Radar WebKit Bug Importer 2023-01-21 10:08:43 PST 
<rdar://problem/104512541>