Bug 250870 - Remove HTMLMediaElement.webkitHasClosedCaptions/webkitClosedCaptionsVisible
Summary: Remove HTMLMediaElement.webkitHasClosedCaptions/webkitClosedCaptionsVisible
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Media (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2023-01-19 16:01 PST by Ahmad Saleem
Modified: 2023-09-08 02:38 PDT (History)
4 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Ahmad Saleem 2023-01-19 16:01:41 PST 
Hi Team,

While going through Blink's commit, I came across another non-standard removal (replaced by Text Track API), so I thought to raise this bug and get input:

Blink Commit - https://src.chromium.org/viewvc/blink?view=revision&revision=159317

WebKit Source - https://searchfox.org/wubkat/source/Source/WebCore/html/HTMLMediaElement.cpp#7056 & https://searchfox.org/wubkat/source/Source/WebCore/html/HTMLMediaElement.idl#98

Just wanted to get input whether it is something worth exploring to clean-up and removal some more code from Webkit while also aiming for standardisation.

Thanks!
Comment 1 Radar WebKit Bug Importer 2023-01-19 16:23:17 PST 
<rdar://problem/104451148>
Comment 2 Karl Dubost 2023-01-19 20:50:22 PST 
Yes I believe this can be safely removed.
It has no impact on both WPT and Browser Compatibility, but it makes it another opportunity to remove code cruft and another vector for detecting safari.
Comment 3 EWS 2023-09-08 02:38:38 PDT 
Committed 267780@main (0a73c4dbb7a0): <https://commits.webkit.org/267780@main>

Reviewed commits have been landed. Closing PR #17501 and removing active labels.