Bug 250858 - Use consistent settings between WebKit/WebKitLegacy/WebCore for audio and video gesture requirements
Summary: Use consistent settings between WebKit/WebKitLegacy/WebCore for audio and vid...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Media (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Brent Fulgham
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2023-01-19 12:44 PST by Brent Fulgham
Modified: 2023-01-20 20:24 PST (History)
1 user (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Brent Fulgham 2023-01-19 12:44:42 PST 
We currently have different names used for WebCore-related media gesture requirements, and the preferences in WebKitLegacy and WebKit with custom code to toggle the WebCore bits in response to the WebKit/WebKitLegacy settings.

Instead, we should let the generator code create the WebCore settings code, which will automatically sync it when WebKit/WebKitLegacy preferences are adjusted.

Since the internal keys used to control the settings are unchanged, this should not modify behavior.
Comment 1 Radar WebKit Bug Importer 2023-01-19 12:45:04 PST 
<rdar://problem/104440786>
Comment 2 Brent Fulgham 2023-01-19 12:52:14 PST 
Pull request: https://github.com/WebKit/WebKit/pull/8849
Comment 3 EWS 2023-01-20 20:24:14 PST 
Committed 259163@main (27ac548bef6e): <https://commits.webkit.org/259163@main>

Reviewed commits have been landed. Closing PR #8849 and removing active labels.