Bug 250817 - Remove templates GCGLSpan & GCGLSpanTuple from GraphicsTypesGL.h
Summary: Remove templates GCGLSpan & GCGLSpanTuple from GraphicsTypesGL.h
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: Other
Hardware: Unspecified Unspecified
: P2 Enhancement
Assignee: Dan Glastonbury
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2023-01-18 18:22 PST by Dan Glastonbury
Modified: 2023-01-19 18:45 PST (History)
4 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Dan Glastonbury 2023-01-18 18:22:16 PST 
To improve compile time of WebCoreArgumentCoders.h move the templates GCGLSpan &
GCGLSpanTuple into their own header to be included by implementations of
GraphicsContextGL. So GraphicsContextGL.h can compile with just forward
declarations, move query functions getFloat, getBoolean, et al, from
GraphicsContextGL.h to GraphicsContextGL.cpp
Comment 1 Radar WebKit Bug Importer 2023-01-18 18:22:55 PST 
<rdar://problem/104407319>
Comment 2 Dan Glastonbury 2023-01-18 22:30:52 PST 
Pull request: https://github.com/WebKit/WebKit/pull/8811
Comment 3 EWS 2023-01-19 18:45:34 PST 
Committed 259124@main (747785fe59b8): <https://commits.webkit.org/259124@main>

Reviewed commits have been landed. Closing PR #8811 and removing active labels.