Bug 250799 - [ews-build.webkit.org] Use super for parent class invocations
Summary: [ews-build.webkit.org] Use super for parent class invocations
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Jonathan Bedard
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2023-01-18 15:27 PST by Jonathan Bedard
Modified: 2023-01-23 13:07 PST (History)
1 user (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Jonathan Bedard 2023-01-18 15:27:52 PST
Throughout ews-build.webkit.org, we should use 'super' instead of explicitly invoking a class function. The reason for this is that 'super' calls will break unit tests very hard if our parent class doesn't have the function we're invoking, while directly invoking a member function of a class we aren't inherited from isn't nessesarily fatal. We're likely to make mistakes here as we switch certain steps to new-style.
Comment 1 Radar WebKit Bug Importer 2023-01-18 15:28:06 PST
<rdar://problem/104400449>
Comment 2 Jonathan Bedard 2023-01-18 15:31:11 PST
Pull request: https://github.com/WebKit/WebKit/pull/8798
Comment 3 EWS 2023-01-23 13:07:04 PST
Committed 259233@main (419bb9a7d871): <https://commits.webkit.org/259233@main>

Reviewed commits have been landed. Closing PR #8798 and removing active labels.