WebKit Bugzilla
New
Browse
Search+
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
250799
[ews-build.webkit.org] Use super for parent class invocations
https://bugs.webkit.org/show_bug.cgi?id=250799
Summary
[ews-build.webkit.org] Use super for parent class invocations
Jonathan Bedard
Reported
2023-01-18 15:27:52 PST
Throughout ews-build.webkit.org, we should use 'super' instead of explicitly invoking a class function. The reason for this is that 'super' calls will break unit tests very hard if our parent class doesn't have the function we're invoking, while directly invoking a member function of a class we aren't inherited from isn't nessesarily fatal. We're likely to make mistakes here as we switch certain steps to new-style.
Attachments
Add attachment
proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1
2023-01-18 15:28:06 PST
<
rdar://problem/104400449
>
Jonathan Bedard
Comment 2
2023-01-18 15:31:11 PST
Pull request:
https://github.com/WebKit/WebKit/pull/8798
EWS
Comment 3
2023-01-23 13:07:04 PST
Committed
259233@main
(419bb9a7d871): <
https://commits.webkit.org/259233@main
> Reviewed commits have been landed. Closing PR #8798 and removing active labels.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug