Bug 250798 - REGRESSION(258644@main): The <select> control looks dark when zooming in
Summary: REGRESSION(258644@main): The <select> control looks dark when zooming in
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Said Abou-Hallawa
URL:
Keywords: InRadar
Depends on:
Blocks: 249168
  Show dependency tree / graph
 
Reported: 2023-01-18 15:20 PST by Said Abou-Hallawa
Modified: 2023-01-24 18:10 PST (History)
4 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Said Abou-Hallawa 2023-01-18 15:20:46 PST 
Calling getRoundedBorderFor() was dropped in 258644@main when refactoring the MenuListButton drawing to go through GraphicsContext. This caused the left and right border gradients to be not clipped. And this made the background of the control part to be filled with the border gradient which is dark gray.

Because we do not have access to the RenderStyle in platform/graphics, we have to calculate getRoundedBorderFor() the control part rect in RenderTheme::paint() and pass it all the way to GraphicsContext and to DisplayList recorder.
Comment 1 Said Abou-Hallawa 2023-01-18 15:21:27 PST 
rdar://104196022
Comment 2 Said Abou-Hallawa 2023-01-18 15:35:44 PST 
Pull request: https://github.com/WebKit/WebKit/pull/8799
Comment 3 EWS 2023-01-24 18:10:44 PST 
Committed 259325@main (b6af447cab8c): <https://commits.webkit.org/259325@main>

Reviewed commits have been landed. Closing PR #8799 and removing active labels.