WebKit Bugzilla
New
Browse
Search+
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
250794
[ews-build.webkit.org] Ensure new-style steps correctly using defers
https://bugs.webkit.org/show_bug.cgi?id=250794
Summary
[ews-build.webkit.org] Ensure new-style steps correctly using defers
Jonathan Bedard
Reported
2023-01-18 14:37:14 PST
When using a new-style buildbot step, the run() command will return a defered object. This means that if we're using '@defer.inlineCallbacks', we need to use defer.returnValue instead of returning something.
Attachments
Add attachment
proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1
2023-01-18 14:37:30 PST
<
rdar://problem/104398102
>
Jonathan Bedard
Comment 2
2023-01-18 14:41:17 PST
Pull request:
https://github.com/WebKit/WebKit/pull/8795
EWS
Comment 3
2023-01-24 07:55:55 PST
Committed
259281@main
(29e63587c7cd): <
https://commits.webkit.org/259281@main
> Reviewed commits have been landed. Closing PR #8795 and removing active labels.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug