Bug 250794 - [ews-build.webkit.org] Ensure new-style steps correctly using defers
Summary: [ews-build.webkit.org] Ensure new-style steps correctly using defers
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Jonathan Bedard
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2023-01-18 14:37 PST by Jonathan Bedard
Modified: 2023-01-24 07:55 PST (History)
1 user (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jonathan Bedard 2023-01-18 14:37:14 PST 
When using a new-style buildbot step, the run() command will return a defered object. This means that if we're using '@defer.inlineCallbacks', we need to use defer.returnValue instead of returning something.
Comment 1 Radar WebKit Bug Importer 2023-01-18 14:37:30 PST 
<rdar://problem/104398102>
Comment 2 Jonathan Bedard 2023-01-18 14:41:17 PST 
Pull request: https://github.com/WebKit/WebKit/pull/8795
Comment 3 EWS 2023-01-24 07:55:55 PST 
Committed 259281@main (29e63587c7cd): <https://commits.webkit.org/259281@main>

Reviewed commits have been landed. Closing PR #8795 and removing active labels.