Bug 250778 - De-duplicate feature flags from Settings.yaml that are provided by UnifiedWebPreferences.yaml
Summary: De-duplicate feature flags from Settings.yaml that are provided by UnifiedWeb...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Brent Fulgham
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2023-01-18 11:39 PST by Brent Fulgham
Modified: 2023-01-19 11:42 PST (History)
1 user (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Brent Fulgham 2023-01-18 11:39:04 PST 
A number of preferences defined in UnifiedWebPreferences.yaml are duplicated in Settings.yaml. The generator handles this case properly, but it's confusing to developers.
Comment 1 Radar WebKit Bug Importer 2023-01-18 11:39:29 PST 
<rdar://problem/104389479>
Comment 2 Brent Fulgham 2023-01-18 11:42:06 PST 
Pull request: https://github.com/Webkit/WebKit/pull/8782
Comment 3 Brent Fulgham 2023-01-18 16:21:40 PST 
Pull request: https://github.com/WebKit/WebKit/pull/8782
Comment 4 EWS 2023-01-19 11:42:56 PST 
Committed 259101@main (6eb6b7e29314): <https://commits.webkit.org/259101@main>

Reviewed commits have been landed. Closing PR #8782 and removing active labels.