Bug 250765 - [ews-build.webkit.org] Use Twisted defer for reviewer queries
Summary: [ews-build.webkit.org] Use Twisted defer for reviewer queries
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Jonathan Bedard
URL:
Keywords: InRadar
Depends on:
Blocks: 250771
  Show dependency tree / graph
 
Reported: 2023-01-18 09:05 PST by Jonathan Bedard
Modified: 2023-01-30 11:38 PST (History)
1 user (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jonathan Bedard 2023-01-18 09:05:23 PST 
We should use Twisted's defer system to make requests listing reviewers for a specific pull-request. Note that we need to do something similar with all our GitHub requests, but piping defers through steps is a somewhat involved process, so we should do this one step at a time.
Comment 1 Radar WebKit Bug Importer 2023-01-18 09:07:36 PST 
<rdar://problem/104382329>
Comment 2 Jonathan Bedard 2023-01-18 09:12:20 PST 
Pull request: https://github.com/WebKit/WebKit/pull/8769
Comment 3 EWS 2023-01-26 09:03:39 PST 
Committed 259427@main (9b7933872a4a): <https://commits.webkit.org/259427@main>

Reviewed commits have been landed. Closing PR #8769 and removing active labels.
Comment 4 Jonathan Bedard 2023-01-30 09:06:21 PST 
Re-opening for pull request https://github.com/WebKit/WebKit/pull/9324
Comment 5 EWS 2023-01-30 11:38:09 PST 
Committed 259577@main (002460d89723): <https://commits.webkit.org/259577@main>

Reviewed commits have been landed. Closing PR #9324 and removing active labels.