Bug 250751 - Replace uses of CallFrame::iterate() with StackVisitor::visit().
Summary: Replace uses of CallFrame::iterate() with StackVisitor::visit().
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Mark Lam
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2023-01-17 20:18 PST by Mark Lam
Modified: 2023-01-18 08:06 PST (History)
1 user (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Mark Lam 2023-01-17 20:18:24 PST 
This is blocking the StackVisitor from dumping the JS stack when we encounter Wasm frames.  The assertion was from back when Wasm frames didn't exist.
Comment 1 Radar WebKit Bug Importer 2023-01-17 20:18:50 PST 
<rdar://problem/104363671>
Comment 2 Mark Lam 2023-01-17 21:37:27 PST 
(In reply to Mark Lam from comment #0)
> This is blocking the StackVisitor from dumping the JS stack when we
> encounter Wasm frames.  The assertion was from back when Wasm frames didn't
> exist.

To clarify, I changed the title to reflect the change I'm actually going to make.  The assertion in the above comment was from inside CallFrame::iterate().  I ended up doing away with this assertion by removing CallFrame::iterate() altogether.
Comment 3 Mark Lam 2023-01-17 21:43:42 PST 
Pull request: https://github.com/WebKit/WebKit/pull/8755
Comment 4 EWS 2023-01-18 08:06:21 PST 
Committed 259027@main (59c35e231667): <https://commits.webkit.org/259027@main>

Reviewed commits have been landed. Closing PR #8755 and removing active labels.