Bug 250729 - Image controls should not be web exposed
Summary: Image controls should not be web exposed
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Aditya Keerthi
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2023-01-17 15:07 PST by Aditya Keerthi
Modified: 2023-01-19 21:49 PST (History)
2 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Aditya Keerthi 2023-01-17 15:07:31 PST 
The following test case incorrectly displays the image controls button:

<style>
    #image-controls {
        width: 100px;
        height: 40px;
        background-color: yellow;
    }
    button {
        width: 60px;
    }
</style>
<body>
    <div id="image-controls" contenteditable="false">
        <button id="image-controls-button"></button>
    </div>
</body>
Comment 1 Radar WebKit Bug Importer 2023-01-17 15:07:58 PST 
<rdar://problem/104352792>
Comment 2 Aditya Keerthi 2023-01-17 15:14:45 PST 
Actually, data:text/html,<button id="image-controls-button"></button> is sufficient to reproduce.
Comment 3 Ryosuke Niwa 2023-01-17 21:25:23 PST 
Maybe we can use shadow DOM for this?
Comment 4 Aditya Keerthi 2023-01-18 10:47:27 PST 
Pull request: https://github.com/WebKit/WebKit/pull/8777
Comment 5 Aditya Keerthi 2023-01-18 10:48:50 PST 
(In reply to Ryosuke Niwa from comment #3)
> Maybe we can use shadow DOM for this?

We already use shadow DOM for this – the issue is due to a logic error.
Comment 6 Ryosuke Niwa 2023-01-18 12:55:16 PST 
(In reply to Aditya Keerthi from comment #5)
> (In reply to Ryosuke Niwa from comment #3)
> > Maybe we can use shadow DOM for this?
> 
> We already use shadow DOM for this – the issue is due to a logic error.

Ah, yeah. Saw your patch.
Comment 7 EWS 2023-01-19 21:49:00 PST 
Committed 259126@main (ac4e9ee871be): <https://commits.webkit.org/259126@main>

Reviewed commits have been landed. Closing PR #8777 and removing active labels.