Bug 250673 - [ATSPI] Implement `AccessibilityUIElement::sortDirection()`
Summary: [ATSPI] Implement `AccessibilityUIElement::sortDirection()`
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Accessibility (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2023-01-16 04:24 PST by Vitaly Dyackhov
Modified: 2023-01-31 01:24 PST (History)
3 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Vitaly Dyackhov 2023-01-16 04:24:23 PST 
It is used in `accessibility/custom-elements/table.html`.
Comment 1 Radar WebKit Bug Importer 2023-01-16 04:24:36 PST 
<rdar://problem/104295981>
Comment 2 Vitaly Dyackhov 2023-01-16 04:26:30 PST 
Pull request: https://github.com/WebKit/WebKit/pull/8686
Comment 3 EWS 2023-01-17 05:27:19 PST 
Committed 258975@main (8d8921074e34): <https://commits.webkit.org/258975@main>

Reviewed commits have been landed. Closing PR #8686 and removing active labels.
Comment 4 Robert Jenner 2023-01-17 17:50:22 PST 
Hello!


I reverted the commit above here:

https://commits.webkit.org/259012@main

Because it broke the following two API-tests on iOS debug:
TestWebKitAPI.AppPrivacyReport.RestoreFromInteractionStateIsNonAppInitiated
TestWebKitAPI.AppPrivacyReport.RestoreFromSessionStateIsNonAppInitiated

HISTORY:
https://results.webkit.org/?suite=api-tests&suite=api-tests&test=TestWebKitAPI.AppPrivacyReport.RestoreFromInteractionStateIsNonAppInitiated&test=TestWebKitAPI.AppPrivacyReport.RestoreFromSessionStateIsNonAppInitiated

I was able to reproduce the timeouts for both tests at iOS 16 Debug ToT running the tests as follows:


run-api-tests --iOS-simulator <insert_test_name_here>

I was also able to confirm that 258975@main is the regression point, as I was able to reproduce the timeout at 258975@main, and not at 258974@main.
Comment 5 Vitaly Dyackhov 2023-01-18 02:50:38 PST 
HISTORY shows that the timeouts keep happening even after the PR was reverted. I'm not sure it's related.
Comment 6 Vitaly Dyackhov 2023-01-19 10:23:34 PST 
Pull request: https://github.com/WebKit/WebKit/pull/8844
Comment 7 EWS 2023-01-31 01:24:32 PST 
Committed 259616@main (0a40902543c1): <https://commits.webkit.org/259616@main>

Reviewed commits have been landed. Closing PR #8844 and removing active labels.