Bug 250630 - Remove out-of-date FIXME on collapsing margins
Summary: Remove out-of-date FIXME on collapsing margins
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2023-01-14 17:45 PST by Ahmad Saleem
Modified: 2023-01-25 09:03 PST (History)
4 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Ahmad Saleem 2023-01-14 17:45:13 PST 
Hi Team,

While going through Blink's commit, I came across following:

Commit - https://chromium.googlesource.com/chromium/blink/+/0a83b0f1a42e3b49e4182a200097c47446f513cc

WebKit Source - https://searchfox.org/wubkat/source/Source/WebCore/rendering/RenderBlockFlow.cpp#1410

I tried the test with the commit and Safari 16.2 is matching with Chrome Canary 111.

I think we can remove this test but would like to get input.

Thanks!
Comment 1 Radar WebKit Bug Importer 2023-01-21 17:46:18 PST 
<rdar://problem/104518616>
Comment 2 EWS 2023-01-25 09:03:39 PST 
Committed 259361@main (b4f7aa580394): <https://commits.webkit.org/259361@main>

Reviewed commits have been landed. Closing PR #9120 and removing active labels.