Bug 250629 - Remove special case for HTMLMediaElement in shouldEventCrossShadowBoundary
Summary: Remove special case for HTMLMediaElement in shouldEventCrossShadowBoundary
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Media (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2023-01-14 17:20 PST by Ahmad Saleem
Modified: 2023-01-25 18:53 PST (History)
4 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Ahmad Saleem 2023-01-14 17:20:29 PST 
Hi Team,

While going through Blink's commit, it seems that they remove this code since it was work-around added for VIMEO website:

Original bug - which added this - bug 61717

WebKit Source - https://searchfox.org/wubkat/source/Source/WebCore/dom/EventPath.cpp#42

Blink Commit - https://chromium.googlesource.com/chromium/blink/+/1e4b0fe0de5ed5e99891932df799a8b000d426c1

Just wanted to raise to get input whether we can safely remove this now.

Thanks!
Comment 1 Radar WebKit Bug Importer 2023-01-21 17:21:15 PST 
<rdar://problem/104518285>
Comment 2 Eric Carlson 2023-01-25 09:40:02 PST 
Yes, as long as the issue doesn’t reproduce with the change removed.
Comment 3 Ahmad Saleem 2023-01-25 09:53:59 PST 
(In reply to Eric Carlson from comment #2)
> Yes, as long as the issue doesn’t reproduce with the change removed.

Just did local build and tried video - https://vimeo.com/336812686

and tried to scrub and see if it does not work etc. as original issue mentioned but seems to work fine.

I will do draft PR and run it through EWS and see if it has any impact.
Comment 4 EWS 2023-01-25 18:53:43 PST 
Committed 259404@main (bb61af8a5102): <https://commits.webkit.org/259404@main>

Reviewed commits have been landed. Closing PR #9126 and removing active labels.