WebKit Bugzilla
New
Browse
Search+
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
250629
Remove special case for HTMLMediaElement in shouldEventCrossShadowBoundary
https://bugs.webkit.org/show_bug.cgi?id=250629
Summary
Remove special case for HTMLMediaElement in shouldEventCrossShadowBoundary
Ahmad Saleem
Reported
2023-01-14 17:20:29 PST
Hi Team, While going through Blink's commit, it seems that they remove this code since it was work-around added for VIMEO website: Original bug - which added this -
bug 61717
WebKit Source -
https://searchfox.org/wubkat/source/Source/WebCore/dom/EventPath.cpp#42
Blink Commit -
https://chromium.googlesource.com/chromium/blink/+/1e4b0fe0de5ed5e99891932df799a8b000d426c1
Just wanted to raise to get input whether we can safely remove this now. Thanks!
Attachments
Add attachment
proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1
2023-01-21 17:21:15 PST
<
rdar://problem/104518285
>
Eric Carlson
Comment 2
2023-01-25 09:40:02 PST
Yes, as long as the issue doesn’t reproduce with the change removed.
Ahmad Saleem
Comment 3
2023-01-25 09:53:59 PST
(In reply to Eric Carlson from
comment #2
)
> Yes, as long as the issue doesn’t reproduce with the change removed.
Just did local build and tried video -
https://vimeo.com/336812686
and tried to scrub and see if it does not work etc. as original issue mentioned but seems to work fine. I will do draft PR and run it through EWS and see if it has any impact.
EWS
Comment 4
2023-01-25 18:53:43 PST
Committed
259404@main
(bb61af8a5102): <
https://commits.webkit.org/259404@main
> Reviewed commits have been landed. Closing PR #9126 and removing active labels.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug