Bug 250628 - [GStreamer] Implement Speech Synthesis with Flite
Summary: [GStreamer] Implement Speech Synthesis with Flite
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKitGTK (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: ChangSeok Oh
URL:
Keywords:
Depends on: 250668
Blocks:
  Show dependency treegraph
 
Reported: 2023-01-14 16:24 PST by ChangSeok Oh
Modified: 2023-01-22 14:47 PST (History)
2 users (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description ChangSeok Oh 2023-01-14 16:24:46 PST
Let's discuss the web speech synthesis for ports using gstreamer here.

We have a working branch: https://github.com/shivamidow/WebKit/tree/eng/speech-synthesis-with-gst-flite

This patch passed 22 / 26 webkit tests in fast/speechsynthesis. 4 test failed due to crash and unknown reasons. We need to investigate it more.
Comment 1 ChangSeok Oh 2023-01-15 12:03:28 PST
I don't want to delay this patch for further bug fixes. It is itself a huge chunk so I suggest splitting the web speech synthesis support into some phases.

Phase 1. Support build and basic functionalities (e.g., play, stop, pause, cancel) -> the current patch
Phase 2. Fix bugs on layout tests (fast/speechsynthesis) and enable the tests
Phase 3. Further bug fixes as we find new ones.

@philn, thought?
Comment 2 ChangSeok Oh 2023-01-15 12:23:29 PST
Or we can enable fast/speechsynthesis in phase 1 but add failed 4 tests as exceptions to fix later.
Comment 3 Philippe Normand 2023-01-15 14:21:22 PST
> Phase 1. Support build and basic functionalities (e.g., play, stop, pause, cancel) -> the current patch

Without GStreamer usage from UIProcess?
Comment 4 ChangSeok Oh 2023-01-15 15:50:29 PST
(In reply to Philippe Normand from comment #3)
> > Phase 1. Support build and basic functionalities (e.g., play, stop, pause, cancel) -> the current patch
> 
> Without GStreamer usage from UIProcess?

Yes. That was fixed already. =)
Comment 5 ChangSeok Oh 2023-01-15 20:52:05 PST
Pull request: https://github.com/WebKit/WebKit/pull/8677
Comment 6 EWS 2023-01-22 14:47:55 PST
Committed 259197@main (f99efce2948a): <https://commits.webkit.org/259197@main>

Reviewed commits have been landed. Closing PR #8677 and removing active labels.