Bug 250605 - MockGamepadProvider is not robust enough and crashes when connection happens before monitoring
Summary: MockGamepadProvider is not robust enough and crashes when connection happens ...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Chirag M Shah
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2023-01-13 17:20 PST by Chirag M Shah
Modified: 2023-01-25 21:23 PST (History)
1 user (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Chirag M Shah 2023-01-13 17:20:24 PST 
<script>
  testRunner.setMockGamepadDetails(0);
  testRunner.connectMockGamepad(0);
  addEventListener('gamepadconnected', () => {});
</script>


Crashes the test runner. We should add hardening against that.
Comment 1 Chirag M Shah 2023-01-13 17:23:15 PST 
rdar://104165858
Comment 2 Chirag M Shah 2023-01-13 17:33:31 PST 
Pull request: https://github.com/WebKit/WebKit/pull/8648
Comment 3 EWS 2023-01-25 21:23:07 PST 
Committed 259411@main (feab6de8fb5e): <https://commits.webkit.org/259411@main>

Reviewed commits have been landed. Closing PR #8648 and removing active labels.