Bug 250591 - REGRESSION (STP 161): html/browsers/the-window-object/open-close 14 test failures on WPT
Summary: REGRESSION (STP 161): html/browsers/the-window-object/open-close 14 test fail...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: Safari Technology Preview
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Chris Dumez
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2023-01-13 13:04 PST by Ahmad Saleem
Modified: 2023-01-19 08:31 PST (History)
5 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Ahmad Saleem 2023-01-13 13:04:16 PST 
Hi Team,

While looking into WPT progression after STP161 release, I noticed that there are 14 regressions as well.

Just raising this bug to track them:

Link - https://wpt.fyi/results/html/browsers/the-window-object/open-close?diff&filter=ADC&run_id=6261567780290560&run_id=5119896183111680

Thanks!
Comment 1 Radar WebKit Bug Importer 2023-01-13 13:13:30 PST 
<rdar://problem/104237236>
Comment 2 Chris Dumez 2023-01-17 13:25:02 PST 
run-webkit-tests --release --no-build --repeat-each=30 --force imported/w3c/web-platform-tests/html/browsers/the-window-object/open-close/open-features-non-integer-innerwidth.html

Passes reliably locally and our expected results are:
```
PASS features "innerwidth=/404" should NOT set "width=404"
PASS features "innerwidth=_404" should NOT set "width=404"
PASS features "innerwidth=L404" should NOT set "width=404"
PASS features "innerwidth=405.5" should set "width=405"
PASS features "innerwidth=405.32" should set "width=405"
PASS features "innerwidth=405LLl" should set "width=405"
PASS features "innerwidth=405^4" should set "width=405"
PASS features "innerwidth=405*3" should set "width=405"
PASS features "innerwidth=405/5" should set "width=405"
PASS features "innerwidth=405  " should set "width=405"
PASS features "innerwidth=405e1" should set "width=405"
PASS features "innerwidth=405e-1" should set "width=405"
```

Not sure why this is reported as failing on wpt.live but passing locally. Could be a timing issue.
Comment 3 Chris Dumez 2023-01-18 12:45:09 PST 
Pull request: https://github.com/WebKit/WebKit/pull/8786
Comment 4 EWS 2023-01-19 08:31:08 PST 
Committed 259084@main (c2ae62c47dc2): <https://commits.webkit.org/259084@main>

Reviewed commits have been landed. Closing PR #8786 and removing active labels.